Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbroken case in ContinuousEffects.java with oneshot effect type #11862

Open
Pendscraper opened this issue Feb 25, 2024 · 1 comment
Open

Unbroken case in ContinuousEffects.java with oneshot effect type #11862

Pendscraper opened this issue Feb 25, 2024 · 1 comment

Comments

@Pendscraper
Copy link

The case for CONTINUOUS does not break or indeed do anything, so it treats it like a one shot. I don't know if this is intentional, but it certainly doesn't look like it; and I have no idea how this code should work. I'm surprised it hasn't broken anything.

if it is correct a comment should probably be added because it certainly doesnt look like it.

image

@JayDi85
Copy link
Member

JayDi85 commented Feb 26, 2024

Prev code version did same (adds to the list). But I agree - it must be researched: if no active breakpoint on it while unit tests run then it must generate unsupported error.

Old code:
IMG_9768

@JayDi85 JayDi85 changed the title Unbroken case in ContinuousEffects.java Unbroken case in ContinuousEffects.java with oneshot effect type Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants