ELD - Throne of Eldraine Set Card Implementation Tracking

[theelk801]

Mark cards you're working on in the second post of this issue.
If you can't check things off, leave a comment instead.
Once the card is committed, check off the card here to show that it's finished.
Don't worry about adding new spoilers to this list, it's generated by a script.

All Sets

Unimplemented Cards

None

Implemented Cards

Click to expand

• Done -- Acclaimed Contender
• Done -- Alela, Artful Provocateur
• Done -- All That Glitters
• Done -- Animating Faerie
• Done -- Arcane Signet
• Done -- Arcanist's Owl
• Done -- Archon of Absolution
• Done -- Ardenvale Paladin
• Done -- Ardenvale Tactician
• Done -- Ayara, First of Locthwain
• Done -- Bake into a Pie
• Done -- Banish into Fable
• Done -- Barge In
• Done -- Barrow Witches
• Done -- Bartered Cow
• Done -- Beanstalk Giant
• Done -- Belle of the Brawl
• Done -- Beloved Princess
• Done -- Blacklance Paragon
• Done -- Bloodhaze Wolverine
• Done -- Blow Your House Down
• Done -- Bog Naughty
• Done -- Bonecrusher Giant
• Done -- Bramblefort Fink
• Done -- Brazen Borrower
• Done -- Brimstone Trebuchet
• Done -- Burning-Yard Trainer
• Done -- Castle Ardenvale
• Done -- Castle Embereth
• Done -- Castle Garenbrig
• Done -- Castle Locthwain
• Done -- Castle Vantress
• Done -- Cauldron Familiar
• Done -- Cauldron's Gift
• Done -- Charmed Sleep
• Done -- Charming Prince
• Done -- Chittering Witch
• Done -- Chulane, Teller of Tales
• Done -- Clackbridge Troll
• Done -- Claim the Firstborn
• Done -- Clockwork Servant
• Done -- Command Tower
• Done -- Corridor Monitor
• Done -- Covetous Urge
• Done -- Crashing Drawbridge
• Done -- Crystal Slipper
• Done -- Curious Pair
• Done -- Dance of the Manse
• Done -- Deafening Silence
• Done -- Deathless Knight
• Done -- Didn't Say Please
• Done -- Doom Foretold
• Done -- Drown in the Loch
• Done -- Dwarven Mine
• Done -- Edgewall Innkeeper
• Done -- Elite Headhunter
• Done -- Embercleave
• Done -- Embereth Paladin
• Done -- Embereth Shieldbreaker
• Done -- Embereth Skyblazer
• Done -- Emry, Lurker of the Loch
• Done -- Enchanted Carriage
• Done -- Epic Downfall
• Done -- Escape to the Wilds
• Done -- Eye Collector
• Done -- Fabled Passage
• Done -- Fae of Wishes
• Done -- Faeburrow Elder
• Done -- Faerie Formation
• Done -- Faerie Guidemother
• Done -- Faerie Vandal
• Done -- Feasting Troll King
• Done -- Fell the Pheasant
• Done -- Ferocity of the Wilds
• Done -- Fervent Champion
• Done -- Festive Funeral
• Done -- Fierce Witchstalker
• Done -- Fireborn Knight
• Done -- Fires of Invention
• Done -- Flaxen Intruder
• Done -- Fling
• Done -- Flutterfox
• Done -- Folio of Fancies
• Done -- Foreboding Fruit
• Done -- Forever Young
• Done -- Fortifying Provisions
• Done -- Foulmire Knight
• Done -- Frogify
• Done -- Gadwick, the Wizened
• Done -- Garenbrig Carver
• Done -- Garenbrig Paladin
• Done -- Garenbrig Squire
• Done -- Garrison Griffin
• Done -- Garruk, Cursed Huntsman
• Done -- Giant Killer
• Done -- Giant Opportunity
• Done -- Giant's Skewer
• Done -- Gilded Goose
• Done -- Gingerbread Cabin
• Done -- Gingerbrute
• Done -- Glass Casket
• Done -- Gluttonous Troll
• Done -- Golden Egg
• Done -- Grumgully, the Generous
• Done -- Happily Ever After
• Done -- Harmonious Archon
• Done -- Henge Walker
• Done -- Heraldic Banner
• Done -- Hushbringer
• Done -- Hypnotic Sprite
• Done -- Idyllic Grange
• Done -- Improbable Alliance
• Done -- Inquisitive Puppet
• Done -- Insatiable Appetite
• Done -- Inspiring Veteran
• Done -- Into the Story
• Done -- Irencrag Feat
• Done -- Irencrag Pyromancer
• Done -- Joust
• Done -- Jousting Dummy
• Done -- Keeper of Fables
• Done -- Kenrith's Transformation
• Done -- Kenrith, the Returned King
• Done -- Knight of the Keep
• Done -- Knights' Charge
• Done -- Korvold, Fae-Cursed King
• Done -- Lash of Thorns
• Done -- Linden, the Steadfast Queen
• Done -- Loch Dragon
• Done -- Lochmere Serpent
• Done -- Locthwain Gargoyle
• Done -- Locthwain Paladin
• Done -- Lonesome Unicorn
• Done -- Lost Legion
• Done -- Lovestruck Beast
• Done -- Lucky Clover
• Done -- Mace of the Valiant
• Done -- Mad Ratter
• Done -- Malevolent Noble
• Done -- Mantle of Tides
• Done -- Maraleaf Pixie
• Done -- Maraleaf Rider
• Done -- Memory Theft
• Done -- Merchant of the Vale
• Done -- Merfolk Secretkeeper
• Done -- Midnight Clock
• Done -- Mirrormade
• Done -- Mistford River Turtle
• Done -- Moonlit Scavengers
• Done -- Murderous Rider
• Done -- Mysterious Pathlighter
• Done -- Mystic Sanctuary
• Done -- Mystical Dispute
• Done -- Oakhame Adversary
• Done -- Oakhame Ranger
• Done -- Oathsworn Knight
• Done -- Ogre Errant
• Done -- Oko's Accomplices
• Done -- Oko's Hospitality
• Done -- Oko, Thief of Crowns
• Done -- Oko, the Trickster
• Done -- Once Upon a Time
• Done -- Once and Future
• Done -- Opportunistic Dragon
• Done -- Opt
• Done -- Order of Midnight
• Done -- Outflank
• Done -- Outlaws' Merriment
• Done -- Outmuscle
• Done -- Overwhelmed Apprentice
• Done -- Piper of the Swarm
• Done -- Prized Griffin
• Done -- Prophet of the Peak
• Done -- Queen of Ice
• Done -- Questing Beast
• Done -- Raging Redcap
• Done -- Rally for the Throne
• Done -- Rampart Smasher
• Done -- Rankle, Master of Pranks
• Done -- Realm-Cloaked Giant
• Done -- Reaper of Night
• Done -- Reave Soul
• Done -- Redcap Melee
• Done -- Redcap Raiders
• Done -- Resolute Rider
• Done -- Return of the Wildspeaker
• Done -- Return to Nature
• Done -- Revenge of Ravens
• Done -- Righteousness
• Done -- Rimrock Knight
• Done -- Robber of the Rich
• Done -- Rosethorn Acolyte
• Done -- Rosethorn Halberd
• Done -- Roving Keep
• Done -- Rowan's Battleguard
• Done -- Rowan's Stalwarts
• Done -- Rowan, Fearless Sparkmage
• Done -- Run Away Together
• Done -- Sage of the Falls
• Done -- Savvy Hunter
• Done -- Scalding Cauldron
• Done -- Scorching Dragonfire
• Done -- Searing Barrage
• Done -- Seven Dwarves
• Done -- Shambling Suit
• Done -- Shepherd of the Flock
• Done -- Shimmer Dragon
• Done -- Shinechaser
• Done -- Shining Armor
• Done -- Signpost Scarecrow
• Done -- Silverflame Ritual
• Done -- Silverflame Squire
• Done -- Silverwing Squadron
• Done -- Skullknocker Ogre
• Done -- Slaying Fire
• Done -- Smitten Swordmaster
• Done -- So Tiny
• Done -- Sorcerer's Broom
• Done -- Sorcerous Spyglass
• Done -- Specter's Shriek
• Done -- Spinning Wheel
• Done -- Sporecap Spider
• Done -- Steelbane Hydra
• Done -- Steelclaw Lance
• Done -- Steelgaze Griffin
• Done -- Stolen by the Fae
• Done -- Stonecoil Serpent
• Done -- Stormfist Crusader
• Done -- Sundering Stroke
• Done -- Syr Alin, the Lion's Claw
• Done -- Syr Carah, the Bold
• Done -- Syr Elenora, the Discerning
• Done -- Syr Faren, the Hengehammer
• Done -- Syr Gwyn, Hero of Ashvale
• Done -- Syr Konrad, the Grim
• Done -- Tall as a Beanstalk
• Done -- Taste of Death
• Done -- Tempting Witch
• Done -- The Cauldron of Eternity
• Done -- The Circle of Loyalty
• Done -- The Great Henge
• Done -- The Magic Mirror
• Done -- The Royal Scions
• Done -- Thorn Mammoth
• Done -- Thornwood Falls
• Done -- Thrill of Possibility
• Done -- Thunderous Snapper
• Done -- Tome Raider
• Done -- Tome of Legends
• Done -- Torbran, Thane of Red Fell
• Done -- Tournament Grounds
• Done -- Trail of Crumbs
• Done -- Trapped in the Tower
• Done -- True Love's Kiss
• Done -- Tuinvale Treefolk
• Done -- Turn into a Pumpkin
• Done -- Unexplained Vision
• Done -- Vantress Gargoyle
• Done -- Vantress Paladin
• Done -- Venerable Knight
• Done -- Wandermare
• Done -- Weapon Rack
• Done -- Weaselback Redcap
• Done -- Wicked Guardian
• Done -- Wicked Wolf
• Done -- Wildborn Preserver
• Done -- Wildwood Tracker
• Done -- Wind-Scarred Crag
• Done -- Wintermoor Commander
• Done -- Wishclaw Talisman
• Done -- Wishful Merfolk
• Done -- Witch's Cottage
• Done -- Witch's Oven
• Done -- Witch's Vengeance
• Done -- Witching Well
• Done -- Wolf's Quarry
• Done -- Workshop Elders
• Done -- Worthy Knight
• Done -- Yorvo, Lord of Garenbrig
• Done -- Youthful Knight

[theelk801]

All cards are implemented (except none of the Adventure cards are available as the actual Adventure mechanic is not yet implemented)

[theelk801]

Additional Tasks

Implement Adventures (rules described here)

• create a subclass of CardImpl with constructor that takes the characteristics of the adventure
• add an attribute adventureSpellAbility that will function like spellAbility does in regular cards
• actually make the whole mess work somehow

Most of the adventure cards are not mechanically complicated, so they've been implemented in a nonfunctional way.

Update TargetAmount to handle differences in targets/amounts

• Sundering Stroke and Forked Lightning both need to target fewer creatures than they deal damage
• Vivien, Arkbow Ranger needs to be able to target "up to" two target creatures, currently has to target at least one.

As always, suggestions are welcome.

[jmharmon]

Some issues on cards I implemented, I'm gonna try fixing those. These screen shots were taken within the last 30 minutes of this posting.

Crystal Slipper doesn't have the first part of the card.

Wishful Merfolk is a mess in general.

[jmharmon]

PR opened for Faerie Vandal

[JayDi85]

• Syr Konrad, the Grim

java.lang.ClassCastException: mage.game.events.GameEvent cannot be cast to mage.game.events.ZoneChangeEvent
        at mage.cards.s.SyrKonradTheGrimTriggeredAbility.checkEventType(SyrKonradTheGrim.java:74)
        at mage.abilities.TriggeredAbilities.checkTriggers(TriggeredAbilities.java:50)
        at mage.game.GameState.handleEvent(GameState.java:705)
        at mage.game.GameImpl.fireEvent(GameImpl.java:2597)
        at mage.players.PlayerImpl.shuffleLibrary(PlayerImpl.java:1616)
        at mage.game.GameImpl.init(GameImpl.java:898)
        at mage.game.GameCommanderImpl.init(GameCommanderImpl.java:74)
        at mage.game.CommanderFreeForAll.init(CommanderFreeForAll.java:31)
        at mage.game.GameImpl.start(GameImpl.java:722)
        at mage.server.game.GameWorker.call(GameWorker.java:34)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)

[MLGMANTIS]

Oko, Thief of Crowns first ability (+2 : Create a Food Token) in game it's coded as (-X : Create Two Food Tokens)

[theelk801]

Thanks for the report, but that one is already fixed and will be in the next release.

[MLGMANTIS]

No problem, sorry about that.

[theelk801]

No apologies needed, bug reports are always appreciated.

[MLGMANTIS]

Out of curiosity, how would I implement the code for cards that aren't in an update yet into my current build of xmage?

[theelk801]

Are you just looking to run the latest build? Check out the guide here. You'll have to clone and build the repository yourself. You can also just connect to the beta server, it's usually close to the latest build.

[MLGMANTIS]

I really wanted to just test the new cards that aren't implemented yet as I think I found a way to break modern hogaak style again using the new troll. I have both servers and clients but i'm just very new at coding. I can of course be patient for the next release. Just curious about how i can go about cloning the repository. Would it take long?

[tsirides]

There is a card missing in the set implementation: Shambling Suit

[theelk801]

@MLGMANTIS cloning the repository doesn't take too long, just follow the steps in the guide.

@tsirides Shambling Suit will be added once its collector number is known

[tsirides]

I made a pull request with some fixes on:

• Inspiring Veteran (he was affecting himself as well and I drew the code from Merfolk Mistbinder)

• Worthy Knight was seeing only Humans instead of Knights, and fixed this as well.

[archalypse]

Arcanist's Owl is not triggering

[theelk801]

Owl is already fixed

[tsirides]

@theelk801 Do you have any idea why I was trying to find the Vantress Gargoyle yesterday and it wasn't showing up? Is it okay for you? On the test build I did from Netbeans.

[theelk801]

Yeah, it was an issue with how I implemented it. I've fixed it now.

[tsirides]

@theelk801

• Vantress Gargoyle is still not showing.
• Inspiring Veteran's text on the card reads Knights you Control get +1/+1

Any ideas why these still happening and how it can be resolved?

[theelk801]

Your database is most likely out of date, check out the instructions here

[tsirides]

I already pushed Stonecoil Serpent @theelk801 and did a pull request.

Fixed the DB problem, thanks! :)

[theelk801]

Thanks, just for future reference leave a comment before you implement the card so I know not to do it.

[tsirides]

Okay sure! sorry for the inconvenience :)

[tsirides]

• in progress -- Blacklance Paragon
• in progress -- Stonecoil Serpent

[MLGMANTIS]

i'm just curious is all, when is the next update of the card database planned? :) I read all the info on the setup of cloning the repository and something went wrong and it didn't work lol. So I gave up haha

[theelk801]

I'm not sure when the next release is but you can always use the beta server.

[archalypse]

I'm not sure when the next release is but you can always use the beta server.

Do we need to use beta? 'cause weren't ELD cards uploaded to every server?

[archalypse]

Fires of Invention allows more than 2 spells per turn.

[TowanDG]

Fabled Passage is always bringing lands untapped, it needs to be when you have four or more lands.

[archalypse]

Rankle, Master of Pranks forces you to choose all 3 every time.

[theelk801]

I pushed a temporary fix for Rankle but it still doesn't let you choose zero modes

[TowanDG]

just a suggestion for coding the adventure from someone that hasnt tried coding cards yet.

code as double sided

giving the cards an ability in hand that casts the adventure side and at resolution places in exile to cast? and naming it as a mechanic.

not sure if itll work properly or not.

[archalypse]

Deathless Knight did not return to my hand when I gained life from a Food Token.

I also tried it during my turn.

[JayDi85]

• The Great Henge:

java.util.NoSuchElementException: No value present
        at java.util.OptionalInt.getAsInt(OptionalInt.java:118)
        at mage.cards.t.TheGreatHengeCostReductionEffect.apply(TheGreatHenge.java:94)
        at mage.abilities.effects.ContinuousEffects.costModification(ContinuousEffects.java:634)
        at mage.players.PlayerImpl.canPlay(PlayerImpl.java:2936)
        at mage.players.PlayerImpl.getPlayable(PlayerImpl.java:3133)
        at mage.players.PlayerImpl.getPlayableObjects(PlayerImpl.java:3288)
        at mage.server.game.GameSessionPlayer.getGameView(GameSessionPlayer.java:192)
        at mage.server.game.GameSessionPlayer.lambda$select$2(GameSessionPlayer.java:63)
        at java.util.Optional.ifPresent(Optional.java:159)
        at mage.server.game.GameSessionPlayer.select(GameSessionPlayer.java:63)
        at mage.server.game.GameController.lambda$select$19(GameController.java:802)
        at mage.server.game.GameController.perform(GameController.java:928)
        at mage.server.game.GameController.perform(GameController.java:921)
        at mage.server.game.GameController.select(GameController.java:802)
        at mage.server.game.GameController.lambda$init$3aa0d15c$2(GameController.java:190)
        at mage.game.events.EventDispatcher.fireEvent(EventDispatcher.java:30)
        at mage.game.events.PlayerQueryEventSource.select(PlayerQueryEventSource.java:41)
        at mage.game.GameImpl.firePriorityEvent(GameImpl.java:2174)

• Memory Theft:

Caused by: java.lang.IllegalStateException: Target wasn't handled. class:class mage.target.common.TargetCardInExile
        at mage.player.ai.ComputerPlayer.choose(ComputerPlayer.java:429)
        at mage.player.ai.ComputerPlayer.choose(ComputerPlayer.java:125)
        at mage.cards.m.MemoryTheftEffect.apply(MemoryTheft.java:80)
        at mage.abilities.AbilityImpl.resolveMode(AbilityImpl.java:176)
        at mage.abilities.AbilityImpl.resolve(AbilityImpl.java:166)
        at mage.game.stack.Spell.resolve(Spell.java:217)
        at mage.player.ai.ComputerPlayer6.resolve(ComputerPlayer6.java:392)
        at mage.player.ai.ComputerPlayer6.addActions(ComputerPlayer6.java:233)

[archalypse]

Covetous Urge does not allow you to cast the exiled card.

[archalypse]

Rankle, Master of Pranks was not fixed with version 4 - it still forces you to choose all 3.

[archalypse]

Syr Konrad seems to be crashing games still.

[imendi7]

Wicked Guardian makes you draw two cards instead of one if 2 damage is dealt to a creature you control

[archalypse]

Run Away Together does nothing

[archalypse]

Keeper of Fables does not trigger the second time when a double strike nonHuman does combat damage.

[archalypse]

The second-card ability still only triggers once per game.

[archalypse]

Sundering Stroke's adamant does not work. With 7 red mana, I chose the first one and it made me choose the damage,w which i put at 7, and then I couldn't chose other targets.

[archalypse]

I need to confirm this, but it seems that covetous urge may open up the entire exile zone to castability (as well as one's graveyard!)

[theelk801]

Sundering Stoke should work fine, the problem is that with the way the rules work you have to divide the damage no matter what, even if you’re just dealing seven to each. We could probably add a note but I’m not sure how.

[JayDi85]

You can use card hints to add extra info (static, dynamic, icon, more) to abilities. Like ability.addHint(new StaticHint('Damage is not damage'h)

[motmontheinternet]

Deafening Silence does nothing, all players are able to cast as many non-creature spells per turn as they like.

[archalypse]

Oakhame Adversary could not be cast for the reduced cost when opponent had a green permanent (Oko)

[archalypse]

Lochmere Servent does not exile cards from the opponent's graveyard.

[DominusMaximus]

1.4.39.dev_2019-09-27_18-55

I attacked with a 2 power Dreadhorde Arcanist and a Syr Faren, the Hengehammer. I ordered their triggers so that the Arcanist's resolves first (choosing a Domri's Ambush in the graveyard targeting Syr Faren). With Syr Faren's trigger, I chose to give the Arcanist +X/+X. Syr Faren's power went up to 3 with the Ambush, but when his triggered ability resolved, it only gave the Arcanist +2/+2.

If I repeat the same scenario with a Giant Growth instead of a Domri's Ambush, Syr Faren's trigger will increase the Arcanist's power and toughness by the correct amount (+5/+5).

[Opchip]

Mark cards you're working on in the second post of this issue.
If you can't check things off, leave a comment instead.
Once the card is committed, check off the card here to show that it's finished.
Don't worry about adding new spoilers to this list, it's generated by a script.

All Sets

Unimplemented Cards

None

Implemented Cards

Click to expand

There is one card missing: Merchant of the Vale // Haggle
https://i.imgur.com/vjjT6Xk.png

[theelk801]

None of the adventures are available yet

[Opchip]

None of the adventures are available yet

I know, but other adventure cards (like Giant Killer) are searchable, so I thought that Merchant of the Vale not doing so was an issue

[scmurray15]

Do we have an ETA on the Adventures?

[Rasbougri]

Defeaning Silence doesn't do anything except cost you 1 mana

[benjaminboz]

Hi

Seems that Improbable Alliance is not working:
The token is created the first time the second card is draw, but then no other token are created during next turns even after two draws.