You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you need to choose card from another player's hand then do not call TargetCardInHand -- it can choose cards from chooser hand only, not from any other hands (see related bug example: #6209). As workaround: replace it with TargetCard.
Smell/broken code -- different players in choose and chooseTarget line:
Also it can freeze the game with empty cards to select (fixed by a072d82)
Cards to check: search by regexp choose.+\.getHand\(\)
TODO:
search, check and fix cards by choose.+\.getHand\(\) (~80 cards to check, if it use different players then replace by TargetCard);
Maybe TODO:
rename TargetCardInHand to TargetCardInSourceHand (current implementation);
add TargetCardInPlayerHand(UUID playerId...
The text was updated successfully, but these errors were encountered:
If you need to choose card from another player's hand then do not call
TargetCardInHand
-- it can choose cards from chooser hand only, not from any other hands (see related bug example: #6209). As workaround: replace it withTargetCard
.Smell/broken code -- different players in
choose
andchooseTarget
line:Also it can freeze the game with empty cards to select(fixed by a072d82)Cards to check: search by regexp
choose.+\.getHand\(\)
TODO:
choose.+\.getHand\(\)
(~80 cards to check, if it use different players then replace byTargetCard
);Maybe TODO:
TargetCardInPlayerHand(UUID playerId...
The text was updated successfully, but these errors were encountered: