What's New Dialog causes freezes on macOS when resizing window

[Alex-Vasile]

When running the beta if you try to use any sort of window management software (e.g. snap XMage to left half of screen) while the "Connect to server" window is open, the entire application will freeze. Digging into it some more, it's cause by the what's new dialog.

When running from source on my M1 Mac, the what's new dialog does not work at all, since the JDK can't find a arm version libjfxwebkit.dylib. (The issue of the UI hanging still happens even when building from source.

Error:

java.lang.UnsatisfiedLinkError: /Users/alex/Library/Java/JavaVirtualMachines/liberica-1.8.0_332/jre/lib/libjfxwebkit.dylib: dlopen(/Users/alex/Library/Java/JavaVirtualMachines/liberica-1.8.0_332/jre/lib/libjfxwebkit.dylib, 0x0001): tried: '/Users/alex/Library/Java/JavaVirtualMachines/liberica-1.8.0_332/jre/lib/libjfxwebkit.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e'))
	at java.lang.ClassLoader$NativeLibrary.load(Native Method)
	at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934)
	at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1817)
	at java.lang.Runtime.load0(Runtime.java:810)
	at java.lang.System.load(System.java:1088)
	at com.sun.glass.utils.NativeLibLoader.loadLibraryFullPath(NativeLibLoader.java:201)
	at com.sun.glass.utils.NativeLibLoader.loadLibraryInternal(NativeLibLoader.java:94)
	at com.sun.glass.utils.NativeLibLoader.loadLibrary(NativeLibLoader.java:39)
	at com.sun.webkit.WebPage.lambda$static$0(WebPage.java:133)
	at java.security.AccessController.doPrivileged(Native Method)
	at com.sun.webkit.WebPage.<clinit>(WebPage.java:132)
	at javafx.scene.web.WebEngine.<init>(WebEngine.java:889)
	at javafx.scene.web.WebEngine.<init>(WebEngine.java:876)
	at javafx.scene.web.WebView.<init>(WebView.java:273)
	at mage.client.dialog.WhatsNewDialog$3.run(WhatsNewDialog.java:264)
	at com.sun.javafx.application.PlatformImpl.lambda$null$5(PlatformImpl.java:295)
	at java.security.AccessController.doPrivileged(Native Method)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$6(PlatformImpl.java:294)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)

[JayDi85]

1. Popup dialogs can be freeze on macos with any third party window or text tools like contexts, magent, etc -- see Mac Client freezes when launching new tourney #4920 for more details. I research it old days and found possible reason in old java's gui lib (AWT) -- maybe will be fixed after migrate to java 11+

2. Miss javafx must be ignored by app and continue to work without any freezes. I'll try to test and find the workaround for macos later.

[Alex-Vasile]

• Popup dialogs can be freeze on macos with any third party window or text tools like contexts, magent, etc -- see Mac Client freezes when launching new tourney #4920 for more details. I research it old days and found possible reason in old java's gui lib (AWT) -- maybe will be fixed after migrate to java 11+
• Miss javafx must be ignored by app and continue to work without any freezes. I'll try to test and find the workaround for macos later.

1. I looked in that issue, I didn't see that you had concluded it to be the popup dialogs. But you're right, it's something about them. However, the "About" page, which is also a popup dialog does not seem to freeze the UI. I might be something about the fact that the other popups have things waiting for response.
2. That was a misspeak on my part. It will continue without it being found, I meant that the UI still freezes when trying to resize the window.

So I should probably just close this issue and update the old one.

[JayDi85]

You can test popup freeze with search language/flag dialog (from connection).

[Alex-Vasile]

You can test popup freeze with search language/flag dialog (from connection).

See #4920 (comment)