New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Several refactors that should be done found during implementing cards #9553
Comments
[[Kami of Celebration]] [[Sunbird's Invocation]] [[Ob Nixilis, the Adversary]] |
Kami of Celebration - (Gatherer) (Scryfall) (EDHREC)
Sunbird's Invocation - (Gatherer) (Scryfall) (EDHREC)
Ob Nixilis, the Adversary - (Gatherer) (Scryfall) (EDHREC)
|
Regarding the apparently unnecessary split/MDFC code in The code in question might be a leftover from when xmage implemented (or attempted to implement) the complex pre-Amonkhet rules. Under the modern rules, there's no reason a EDIT: I just checked the Amonkhet rules update diff and the rule quoted in the comment in |
Wear // Tear - (Gatherer) (Scryfall) (EDHREC)
Counterbalance - (Gatherer) (Scryfall) (EDHREC)
|
Leftover TODOs from #9328:
MoveCounterFromTargetToTargetEffect
should be refactored to a common classSpellCastControllerTriggeredAbility
'sfromZone
(e.g. Kami of Celebration, Sunbird's Invocation)TargetOfOpponentsSpellOrAbilityTriggeredAbility
andBecomesTargetControlledPermanentTriggeredAbility
into a single class for "Whenever {a} becomes the target of a {b}" that takes filters for both {a} and {b}.RefactorClean up and double check by [NCC] Implementation remainder of cards #9328 (comment)MageObject.getColor(game)
so that it handles the intricacies of MDFC and split cards internally rather than needing to be wrapped externally.The text was updated successfully, but these errors were encountered: