-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save_dataset_statistics broken with DDSP 3.2.0? #427
Comments
I have the same exact problem. I´m not that thrilled to see that this happened to you in March and there´s still no replys too. |
I just tried the same thing locally and I'm getting the same error. |
@sharp-trickster @theloni-monk I'm no longer working on this, but if I recall correctly the issue is the the data_provider = ddsp.training.data.TFRecordProvider(
args.train_tfrecord_filepattern,
# Make sure these arguments match what the dataset was created with!
# sample_rate=44100,
frame_rate=50,
centered=True,
with_jukebox=False,
) Look for See also the updated script I made for my thesis. |
Anybody ever solved this? |
@olaviinha see my comment above, it's about the arguments to the |
Granted, I am having this problem with version 3.5.0, thought perhaps issue might have been the same. I saw it, and tried it, but sadly to no avail. The default values of these parameters seem to match. I tried to match them manually in the notebook as well as changing them in both place to these values in your example, but still getting the same frame_size vs. hop_size error. |
I am experiencing the same issue. The arguments match, so I don't know what is wrong. My audio is 16 khz also. Did anyone figure out a solution to this? |
I have fixed it by coping codes out and modifying the parameters of compute_dataset_statistics in save_dataset_statistics.
|
Hi, I'm trying to run the code from the
train_autoencoder
notebook with a newer DDSP version (3.2.0). I made a little script that wrapssave_dataset_statistics
:This produces the following output:
I'm running on the same violin files mentioned in this paper.
My guess is that this is because padding was added after this notebook and the default arguments now break it somehow.
I would submit a pull request to fix this but I'm not too familiar with the codebase so I'm not sure which one to choose: disable padding in this case or change the arguments so that hop size becomes smaller?
The text was updated successfully, but these errors were encountered: