Fix dependencies. There was a breaking change so need to pin to hmmlearn<=0.2.7. Fixes slow install from #460. Removes strict version (== to <= >=). Also just add a "downloads" badge for fun. #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_478232230
branch
from
df5cad8
to
a1131ee
Compare
|
Regarding all these recent pinnings: Would it be possible to use Trying to use ddsp as a library in conjuction with other libraries that come with their own set of dependencies is basically impossible currently now that ddsp uses hard pinnings. Using dependency ranges instead gives the dependency resolution at least some degree of freedom to find a fitting version. |
|
That's very reasonable, I'll give it a shot |
copybara-service
bot
force-pushed
the
test_478232230
branch
from
a1131ee
to
0d8a948
Compare
Cool, thanks! |
copybara-service
bot
force-pushed
the
test_478232230
branch
2 times, most recently
from
2831657
to
2eb9629
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_478232230
branch
from
2eb9629
to
e2f3af4
Compare
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dependencies. There was a breaking change so need to pin to hmmlearn<=0.2.7. Fixes slow install from #460. Removes strict version (== to <= >=). Also just add a "downloads" badge for fun.