Fix Issue #341: Missing flute_scale_with_png.mxl file #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase your change onto master so it has only the last commit? Or alternatively, resync with magenta/master and create a new branch that has only the commit to add the file. |
added 28 commits
November 2, 2016 19:07
…and key signatures
…Fix tempo parsing errors
… MusicXMLParserState object
… by reading the symbolic note durations from the MusicXML. This completes Douglas Eck's TODO.
…Magenta. Also raise exception for unknown pitch steps
… handle parse errors. Fix MIDI program and channel mapping
added 3 commits
November 2, 2016 19:08
cghawthorne
approved these changes
Nov 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add this test file in pull request #214. This file has now been added. It is a compressed MusicXML file with two rootfiles: the uncompressed MusicXML file and a PNG file of the notation.