Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken modularity in InventoryCatalog #212

Closed
naydav opened this issue Nov 20, 2017 · 1 comment
Closed

Broken modularity in InventoryCatalog #212

naydav opened this issue Nov 20, 2017 · 1 comment
Assignees
@bartekszymanski
Labels
Bug

Comments

@naydav
Copy link

naydav commented Nov 20, 2017

  1. We have logic related to InventorySales in InventoryCatalog
    \Magento\InventoryCatalog\Ui\Component\Control\Stock\DeleteButton
    Need to move this class to InventorySales module

  2. \Magento\InventoryCatalog\Ui\Component\Control\Stock\DeleteButton has been created but button is not used
    Need to overwrite inventory_stock_form.xml in InventorySales module
    In this class need to overwrite node
    <button name="delete" class="Magento\Inventory\Ui\Component\Control\Stock\DeleteButton"/>
    on <button name="delete" class="Magento\InventorySales\Ui\Component\Control\Stock\DeleteButton"/>
@naydav naydav added the Bug label Nov 20, 2017
@naydav naydav changed the title Modularity fixing Broken modularity in InventoryCatalog Nov 20, 2017
@bartekszymanski bartekszymanski mentioned this issue Nov 21, 2017
Merged
@naydav
Copy link
Author

naydav commented Nov 22, 2017

#215

@naydav naydav closed this as completed Nov 22, 2017
magento-devops-reposync-svc pushed a commit that referenced this issue Apr 19, 2022
@sivaschenko
Merge pull request #212 from magento-commerce/api-changes-develop
0f0eaf1 
[Lynx] Add Missing API Declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartekszymanski bartekszymanski

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naydav @bartekszymanski