Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused exception processing in controller #233

Closed
naydav opened this issue Nov 25, 2017 · 0 comments
Closed

Remove unused exception processing in controller #233

naydav opened this issue Nov 25, 2017 · 0 comments
Assignees
@vovsky

Comments

@naydav
Copy link

naydav commented Nov 25, 2017

In \Magento\Inventory\Controller\Adminhtml\Stock\Delete we have processing of
\Magento\Framework\Exception\NoSuchEntityException

But \Magento\InventoryApi\Api\StockRepositoryInterface::deleteById doesn't throw this exception
So need to remove catch from controller
@vovsky vovsky self-assigned this Nov 25, 2017
vovsky added a commit that referenced this issue Nov 25, 2017
@vovsky
#233 Removed unused exception processing in Admin Stock Delete contro…
2f748bb 
…ller
@vovsky vovsky mentioned this issue Nov 25, 2017
Merged
maghamed added a commit that referenced this issue Nov 25, 2017
@maghamed
Merge pull request #249 from magento-engcom/233-remove-unused-excepti…
aa8a684 
…on-processing-in-controller

#233 Removed unused exception processing in Admin Stock Delete contro…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vovsky vovsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@naydav @vovsky @maghamed