Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module uninstall does not update .gitignore #125

Open
vernard opened this issue Aug 1, 2014 · 0 comments
Open

Module uninstall does not update .gitignore #125

vernard opened this issue Aug 1, 2014 · 0 comments
Milestone

Comments

@vernard
Copy link

vernard commented Aug 1, 2014

I set auto-append-gitignore to true and the .gitignore updates after installing a module.

However when I remove a module, it doesn't remove the deleted contents of the module.

Scenario:

Here's my composer.json:

    "require": {
        "vendor/custom-module": "*",
        "magento-hackathon/magento-composer-installer": "*"
    }
    "extra": {
        "auto-append-gitignore": true,
        "magento-root-dir": "htdocs",
    }

Considering that custom-module is a valid magento-module, it will be installed with symlinks and the .gitignore will have the symlinked files ignored.

Then I remove the custom module. and having this composer.json:

    "require": {
        "magento-hackathon/magento-composer-installer": "*"
    }
    "extra": {
        "auto-append-gitignore": true,
        "magento-root-dir": "htdocs",
    }

And run composer update.

.gitignore still ignores the files of the custom-module.

@Flyingmana Flyingmana added this to the Version 3.0.0 milestone Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants