Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search API endpoint implementation #3

Closed
sidolov opened this issue Apr 30, 2019 · 3 comments
Closed

Search API endpoint implementation #3

sidolov opened this issue Apr 30, 2019 · 3 comments
Assignees
@kkdg
Labels
Backend Complex
Projects
Backlog
Milestone
Phase 1: Search &...

Comments

@sidolov
Copy link
Contributor

sidolov commented Apr 30, 2019 •
edited
Loading

Description

  • Define an interface for the API endpoint
  • Implement request builder
  • Define request builder configuration is defined in XML and extensible for 3d party developers:
    • Filters configuration
    • Sorting configuration
    • Pagination configuration
  • Define GET web-api endpoint for search
  • Cover endpoints with the unit, web-api integration tests

Documentation

Story: User accesses stock images from Magento Admin
Design document: Adobe Stock Image Search Design

QA notes

  • User can view 32 images from Adobe Stock
  • Tests are passing
@sidolov sidolov added this to Ready for Grooming in Backlog May 1, 2019
@sidolov sidolov added this to the Phase 1 milestone May 2, 2019
@sidolov sidolov mentioned this issue May 2, 2019
Closed
@kkdg kkdg self-assigned this May 12, 2019
@sidolov sidolov moved this from Ready for Grooming to Dev In Progress in Backlog May 12, 2019
@kkdg
Copy link

kkdg commented May 30, 2019

Working on this,

@sidolov sidolov self-assigned this May 30, 2019
sidolov pushed a commit to sidolov/adobe-stock-integration that referenced this issue May 30, 2019
magento#3: Refactored API structure
1629d25
sidolov pushed a commit to sidolov/adobe-stock-integration that referenced this issue May 30, 2019
magento#3: Client refactoring
2135667
@sidolov sidolov mentioned this issue May 30, 2019
Merged
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Backlog May 30, 2019
@kkdg
Copy link

kkdg commented May 31, 2019

Thanks

sidolov pushed a commit to sidolov/adobe-stock-integration that referenced this issue May 31, 2019
magento#3: Filters support
4a35101
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in Backlog Jun 4, 2019
@sidolov
Copy link
Contributor Author

sidolov commented Jun 4, 2019

Hi @kkdg , please, check the last commits to the develop branch, we have already implemented the API endpoint and I'm going to close this issue as done.

@sidolov sidolov closed this as completed Jun 7, 2019
@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in Backlog Jun 7, 2019
@sivaschenko sivaschenko mentioned this issue Aug 12, 2019
Merged
mmansoor-magento pushed a commit that referenced this issue Feb 12, 2021
@zakdma
Merge pull request #3 from magento-tsg/MC-38817
6512ee8 
[Arrows] MC-38817: [MFTF] fix some ASI tests because of bad design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkdg kkdg

Labels
Backend Complex
Projects
Backlog
  
Done
Milestone
Phase 1: Search & Preview Images
Development

No branches or pull requests
2 participants
@kkdg @sidolov