Polpulate asset metadata on uploading the image to magento && Populate media asset description when saving image from adobe stock #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate media asset description when saving image from adobe stock
|
@magento run all tests |
|
@magento run all tests |
|
@magento run all tests |
4 tasks
|
@magento run all tests |
|
@magento run all tests |
|
@magento run all tests |
|
@magenti run all tests |
|
@magento run all tests |
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
gabrieldagama
suggested changes
Jul 16, 2020
There was a problem hiding this comment.
Hi @Nazar65, thanks for the pull request, it looks great! Please follow some comments below, let me know if you have any questions.
|
@magento run all tests |
|
@magento run all tests |
|
@magento run Static Tests |
m2-community-project
bot
moved this from Ready for Delivery
to Review in Progress
in Pull Request Progress
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for delivery
labels
sivaschenko
requested changes
Jul 22, 2020
|
@magento run all tests |
|
@magento run all tests |
|
@magento run all tests |
sivaschenko
approved these changes
Jul 23, 2020
sivaschenko
moved this from Review in Progress
to Acceptance Testing
in Pull Request Progress
m2-community-project
bot
added
Progress: acceptance testing
and removed
Progress: review
labels
|
✔️ QA Passed The locally uploaded jpeg image has Details, Description and Tags |
chalov-anton
moved this from Acceptance Testing
to Ready for Delivery
in Pull Request Progress
m2-community-project
bot
added
Progress: ready for delivery
and removed
Progress: acceptance testing
labels
|
Hi @Nazar65, thank you for your contribution! |
m2-community-project
bot
moved this from Ready for Delivery
to Done
in Pull Request Progress
m2-community-project
bot
added
Progress: done
and removed
Progress: ready for delivery
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Should be checked for the next scenarios:
bin/magento media-gallery:syncfor images added manually to pub/media directory