Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of PNG IPTC reading && writing to MediaGalleryMetadata module implementation #1675

Merged
merged 17 commits into from
Aug 2, 2020
Merged

Add support of PNG IPTC reading && writing to MediaGalleryMetadata module implementation #1675

merged 17 commits into from
Aug 2, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jul 29, 2020 •
edited

Description (*)

Fixed Issues (if relevant)

  1. Fixes Add support of PNG IPTC reading to MediaGalleryMetadata module implementation #1553: Add support of PNG IPTC reading to MediaGalleryMetadata module implementation
  2. Fixes Add support of PNG IPTC writing to MediaGalleryMetadata module implementation #1669: Add support of PNG IPTC writing to MediaGalleryMetadata module implementatio

Manual testing scenarios (*)

  1. ...
  2. ...

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jul 29, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 29, 2020

@magento run all tests

@Nazar65 Nazar65 changed the title Add support of PNG IPTC reading to MediaGalleryMetadata module implementation Add support of PNG IPTC reading && writing to MediaGalleryMetadata module implementation Jul 30, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 30, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 30, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 30, 2020

@magento run all tests

@Nazar65 Nazar65 added the MFTF tests MFTF tests coverage label Jul 30, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 30, 2020

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 30, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 30, 2020

@magento run all tests

@m2-community-project m2-community-project bot moved this from Ready for Review to Acceptance Testing in Pull Request Progress Aug 2, 2020
@sivaschenko sivaschenko merged commit e7d66c2 into magento:2.0-develop Aug 2, 2020
@ghost
Copy link

ghost commented Aug 2, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Acceptance Testing to Done in Pull Request Progress Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

Labels
MFTF tests MFTF tests coverage Progress: done
Projects
Pull Request Progress
  
Done
Milestone
No milestone
2 participants
@Nazar65 @sivaschenko