Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MFTF test to locate previewed image #713

Merged
merged 7 commits into from
Nov 20, 2019
Merged

Added MFTF test to locate previewed image #713

merged 7 commits into from
Nov 20, 2019

Conversation

drpayyne
Copy link
Contributor

Description

Developed MFTF test to test the Locate button of a previewed image

Fixed Issues

Manual testing scenarios

  • Add magento/ADOBE_STOCK_UNLICENSED_IMAGE credential with the image ID of an unlicensed image
  • vendor/bin/mftf run:test AdminAdobeStockPreviewedNotLicensedImageLocateTest --remove

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Nov 14, 2019
@drpayyne drpayyne changed the title Issue 446 Added MFTF test to locate previewed image Nov 14, 2019
@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 14, 2019 •
edited

Notes:

  1. Had to move image deletion ActionGroup to the end of the test instead of the <after/> node as currently data cannot be passed from a test to the <after/> node (reference)
  2. Couldn't condense the final steps of the test into an ActionGroup as currently data cannot be passed between ActionGroups either (reference)

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Nov 20, 2019
@sivaschenko sivaschenko merged commit aca043e into magento:develop Nov 20, 2019
@ghost
Copy link

ghost commented Nov 20, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@filmaj filmaj Awaiting requested review from filmaj

Assignees

@sivaschenko sivaschenko

Labels
Award: MFTF test coverage Partner: Zilker Technology partners-contribution
Projects
Pull Request Progress
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drpayyne @sivaschenko @magento-engcom-team