Proposal for adding a composer update lookahead to resolve root conflicts #18
Conversation
…ser.json conflicts
|
Review requested: @buskamuza |
|
This is all possible using a Composer plugin; I have a proof-of-concept attaching custom parameters and composer modification functionality to the Question: Is it necessary to address non- |
|
I think this should live in its own git repo and be versioned independently, as it should have no problems being compatible with earlier Magento versions, plus it's not an actual Magento module. Do you see any issue with that? By necessity it doesn't have any actual composer requirements on any other Magento packages. |
| @@ -0,0 +1,48 @@ | |||
| # Add Lookahead for Pre-`composer update` Changes | |||
| > _Related JIRA ticket: [MAGETWO-94153](https://jira.corp.magento.com/browse/MAGETWO-94153)_ | |||
There was a problem hiding this comment.
Please don't reference internal resources here as they're not accessible for outside people.
| # Add Lookahead for Pre-`composer update` Changes | ||
| > _Related JIRA ticket: [MAGETWO-94153](https://jira.corp.magento.com/browse/MAGETWO-94153)_ | ||
| ## Context | ||
| With Magento 2.3, we needed to [add additional steps to the upgrade process](https://devdocs.magento.com/guides/v2.3/comp-mgr/cli/cli-upgrade.html) due to incompatibilities with dependencies in the root `composer.json` file. Without the fixed requirements, the `composer update` command fails to install the new version of Magento because it has conflicts with the root requirements, and 2.3 code can't fix those requirements before it is installed because it would need to be installed in order to run the code. |
There was a problem hiding this comment.
Could you please include link to the specific section?
| ## Implementation Strategy | ||
| There are a few hiccups in the actual implementation. | ||
| - The upgrade needs to be able to handle starting at any previous Magento version, each of which could have different values that need to be added, changed, or removed. | ||
| - There are potentially non-Composer updates that need to be made, such as `magento/updater`, which exists in the top-level Magento directory but is not its own composer package. |
There was a problem hiding this comment.
Please, take into account a case when Updater application is absent.
With Magento 2.3, we needed to add additional steps to the upgrade process due to incompatibilities with dependencies in the root
composer.jsonfile. Without the fixed requirements, thecomposer updatecommand fails to install the new version of Magento because it has conflicts with the root requirements, and 2.3 code can't fix those requirements before it is installed because it would need to be installed in order to run the code.In the future, we are likely to encounter this issue again, especially during upgrades where we drop support for old PHP versions (PHP 7.1 will soon stop receiving security patches, for example). To avoid needing to add more manual steps for each version, we should add hooks to the upgrade process so any installations that start at 2.3 or higher check the target version for changes that need to be made before it is installed.
See the changed file for the proposed solution.