Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with 2.4-develop #403

Closed
wants to merge 1 commit into from
Closed

Sync with 2.4-develop #403

wants to merge 1 commit into from

Conversation

mslabko
Copy link
Member

@mslabko mslabko commented Oct 23, 2020 •
edited by vgoncharenko

Description (*)

Related Pull Requests

magento/magento2#30595
https://github.com/magento/partners-magento2ee/pull/389
https://github.com/magento/saas-export/pull/153

Fixed Issues (if relevant)

  1. Fixes magento/catalog-storefront#<issue_number>

Questions or comments

Code Review Checklist (*)

See detailed checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatible changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

@mslabko
Copy link
Member Author

mslabko commented Oct 23, 2020

@magento run all tests

@mslabko mslabko changed the title Create test Sync with 2.4-develop Oct 23, 2020
This was referenced Oct 24, 2020
Open
Closed
@mslabko
Copy link
Member Author

mslabko commented Oct 26, 2020

@magento run Integration Tests
with editions EE
with env PHP 7.4, database MySQL 8

@mslabko
Copy link
Member Author

mslabko commented Oct 26, 2020

@magento run Integration Tests
with editions EE
with env PHP 7.4, database MySQL 8.0

1 similar comment
@mslabko
Copy link
Member Author

mslabko commented Oct 26, 2020

@magento run Integration Tests
with editions EE
with env PHP 7.4, database MySQL 8.0

@mslabko
Copy link
Member Author

mslabko commented Oct 26, 2020

@magento run Unit Tests
with editions EE
with env PHP 7.4, database MySQL 8.0

@mslabko
Copy link
Member Author

mslabko commented Oct 26, 2020

@magento run Unit Tests

@magento-engcom-team magento-engcom-team mentioned this pull request Oct 26, 2020
Closed
@mslabko
Copy link
Member Author

mslabko commented Oct 26, 2020

@magento run all tests
with editions EE

@magento-engcom-team magento-engcom-team mentioned this pull request Oct 26, 2020
Closed
@vgoncharenko
Copy link
Contributor

@magento run Integration Tests

4 similar comments
@vgoncharenko
Copy link
Contributor

@magento run Integration Tests

@vgoncharenko
Copy link
Contributor

@magento run Integration Tests

@vgoncharenko
Copy link
Contributor

@magento run Integration Tests

@vgoncharenko
Copy link
Contributor

@magento run Integration Tests

@mslabko mslabko closed this Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mslabko @vgoncharenko