Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom product attribute groups empty when migrating from 1.9.2.2 to 2.4.3 #888

Open
schnere opened this issue Feb 13, 2022 · 5 comments
Open

Comments

@schnere
Copy link

schnere commented Feb 13, 2022

When migrating from Magento 1.9.2.2 to 2.4.3 the custom product attribute group mapping does not work as expected.
This error causes the custom attribute groups to be empty after migration.

Preconditions

  • Source Magento 1.9.2.2
  • Target: Magento 2.4.3-p1
  • PHP 7.4
  • A custom module Foo_Migration is used to map custom attributes, tables, etc.

Steps to reproduce

  1. Starting with Magento 1.9.2.2 having an attribute set with custom attribute groups with attributes assigned
  2. Migrate data to Magento 2.4.3
  3. The custom attribute group has no attributes assigned

Expected result

After migration the custom product attribute group should have the same product attributes assigned as in source Magento.

Actual result

The custom product attribute groups are empty.

Additional notes

I found the problem here:

if ($sourceKey == $destinationKey) {

If I have a group "MyCustomGroup" in Source it get's compared with "Migration_MyCustomGroup". This will never be true as the source lacks of the Prefix. As the mapping is not set here it will not be executed later.

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2022

Hi @schnere. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@schnere
Copy link
Author

schnere commented Feb 13, 2022

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2022

Hi @schnere! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@schnere
Copy link
Author

schnere commented Feb 13, 2022

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2022

Hi @schnere! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

schnere added a commit to schnere/data-migration-tool that referenced this issue Feb 16, 2022
schnere added a commit to schnere/data-migration-tool that referenced this issue Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant