Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security scan instructions incorrect #1751

Closed
terolahtinen opened this issue Mar 12, 2018 · 2 comments
Closed

Security scan instructions incorrect #1751

terolahtinen opened this issue Mar 12, 2018 · 2 comments
Assignees

Comments

@terolahtinen
Copy link

Thank you for the great security scan tool.

Unfortunately, the instructions provided do not take into account that Magento 2 is a very buggy software.

Click Content > Design > Configuration. In the Action column, click Edit next to the website.
To add the code to the HTML head, expand HTML Head. Enter the code in the Scripts and Style Sheets field.
When you're finished, click Save Configuration.

This does not save the configuration, see Magento 2 issues 5288 and 5666.
magento/magento2#5288
magento/magento2#5666

The instructions should be updated with something that actually works with Magento 2.

jeff-matthews pushed a commit to likemusic/devdocs that referenced this issue Mar 20, 2018
@jfrontain
Copy link
Contributor

Hi @terolahtinen, just acknowledging that we've received your issue and hope to resolve it in the next week or two. Thanks for your patience.

@jfrontain
Copy link
Contributor

@terolahtinen, thanks for logging this issue, and we’re glad to hear that you find the Security Scanner tool helpful. Our Security scanner team has confirmed that the instructions for the following supported versions of Magento 2 (2.0.18, 2.1.12, 2.2.3. 2.3.0) are accurate, and they will not update the instructions for earlier versions. We’re closing this issue, but we encourage you to log issues as needed for the Magento versions listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants