Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on page: /guides/v2.3/extension-dev-guide/versioning/dependencies.html #4278

Closed
robsch opened this issue Apr 17, 2019 · 1 comment
Closed
Assignees

Comments

@robsch
Copy link

robsch commented Apr 17, 2019

Isn't this contradictory on the page:

  1. Do not specify a dependency on meta packages (e.g. product-community-edition).

But on Check the Magento version one way is to look into the composer.lock file and look at magento/product-community-edition to find out the version.

So why not specify a dependy to product-community-edition?

@keharper
Copy link
Contributor

@robsch The "Module version dependencies" topic discusses versioning considerations when developing a new module. The "Check the Magento version' topic just lists the least-preferred way to determine what version you're currently running. There's no contradiction here.

@keharper keharper self-assigned this Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants