Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/graphql-ce# New topic - Check the Magento version #4152

Merged
merged 18 commits into from Apr 17, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Apr 3, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will add a new topic "Check the Magento version" to PHP Developer Guide > Versioning.

Additional information

List all affected URLs

@keharper , could you please review?

Thank you!

whatsnew
Added the "Check the Magento version" topic.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@jeff-matthews jeff-matthews added this to Backlog in Processing PRs via automation Apr 3, 2019
Processing PRs automation moved this from Backlog to Needs writer approval Apr 3, 2019
guides/v2.3/mrg/ce/Version.md Outdated Show resolved Hide resolved
guides/v2.3/mrg/ce/Version.md Outdated Show resolved Hide resolved
@osrecio osrecio self-assigned this Apr 3, 2019
@keharper keharper self-assigned this Apr 3, 2019
Processing PRs automation moved this from Needs writer approval to Needs testing Apr 8, 2019
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is ok.

Thanks @atwixfirster :)

@atwixfirster atwixfirster changed the title magento/graphql-ce# Magento_Version module magento/graphql-ce# New topic - Check the Magento version Apr 9, 2019
title: Check the Magento version
---

There are the next ways how to get a version of Magento store:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are the next ways how to get a version of Magento store:
Use any of the following ways to determine which version of Magento is installed:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

---

There are the next ways how to get a version of Magento store:
- through command line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- through command line
- From the command line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


There are the next ways how to get a version of Magento store:
- through command line
- through HTTP GET request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- through HTTP GET request
- With an HTTP GET request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

There are the next ways how to get a version of Magento store:
- through command line
- through HTTP GET request
- from Magento backend (admin account is required)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- from Magento backend (admin account is required)
- From within the Magento Admin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

- through command line
- through HTTP GET request
- from Magento backend (admin account is required)
- from `composer.lock` file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- from `composer.lock` file
- By viewing the `composer.lock` file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

```

#### HTTP GET request
HTTP request allows to get a short information about Magento version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HTTP request allows to get a short information about Magento version.
An HTTP request returns less detailed information about the Magento version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented

Magento/2.3 (Community)
```

#### Magento backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Magento backend
## Magento Admin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented


#### Magento backend

Login as a registered admin user into back-end side of your Magento store. Then go to the bottom of the page. Magento version will be displayed in the right corner above "Account Activity" and "Report an Issue" links:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Login as a registered admin user into back-end side of your Magento store. Then go to the bottom of the page. Magento version will be displayed in the right corner above "Account Activity" and "Report an Issue" links:
Login to Magento as a registered Admin user. The Magento version is displayed at the bottom right of the page, above the **Account Activity** and **Report an Issue** links:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented


![Check the Magento version]({{ page.baseurl }}/extension-dev-guide/images/version.png)

#### File `composer.lock`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### File `composer.lock`
## The `composer.lock` file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

![Check the Magento version]({{ page.baseurl }}/extension-dev-guide/images/version.png)

#### File `composer.lock`
Please note that Magento reads current version from the `composer.lock` file that locates in the root of the store. If you want to get Magento version from this file then make search for `magento/product-community-edition` (if you use community edition) or `magento/product-enterprise-edition` (if you use commerce version):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please note that Magento reads current version from the `composer.lock` file that locates in the root of the store. If you want to get Magento version from this file then make search for `magento/product-community-edition` (if you use community edition) or `magento/product-enterprise-edition` (if you use commerce version):
Magento reads the current version from the `<Magento_root>/composer.lock` file. To determine the Magento version, search for `magento/product-community-edition` or `magento/product-enterprise-edition`, depending on which version of Magento is installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify this statement. I don't see any reference to magento/product here:
https://github.com/magento/magento2/blob/2.3-develop/composer.lock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify this statement. I don't see any reference to magento/product here:
https://github.com/magento/magento2/blob/2.3-develop/composer.lock

I've verified this step within debug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keharper , all changes have been implemented. 🎉

Could you please review?

Thank you!

Processing PRs automation moved this from Needs testing to Needs writer approval Apr 16, 2019
@keharper keharper added 2.x New Topic A major update published as an entirely new document labels Apr 16, 2019
Processing PRs automation moved this from Needs writer approval to Needs testing Apr 17, 2019
@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 6bca4db into magento:master Apr 17, 2019
Processing PRs automation moved this from Needs testing to Done Apr 17, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Thanks so much for another new topic, @atwixfirster

@jeff-matthews
Copy link
Contributor

@keharper, please add a "whatsnew" description to the end of the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants