Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/graphql-ce# New topic - Check the Magento version #4152

Merged
merged 18 commits into from Apr 17, 2019

Conversation

@atwixfirster
Copy link
Contributor

commented Apr 3, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will add a new topic "Check the Magento version" to PHP Developer Guide > Versioning.

Additional information

List all affected URLs

@keharper , could you please review?

Thank you!

whatsnew
Added the "Check the Magento version" topic.

@devops-devdocs

This comment has been minimized.

Copy link

commented Apr 3, 2019

An admin must run tests on this PR before it can be merged.

@jeff-matthews jeff-matthews added this to Backlog in Processing PRs via automation Apr 3, 2019

Processing PRs automation moved this from Backlog to Needs writer approval Apr 3, 2019

Show resolved Hide resolved guides/v2.3/mrg/ce/Version.md Outdated
Show resolved Hide resolved guides/v2.3/mrg/ce/Version.md Outdated

@osrecio osrecio self-assigned this Apr 3, 2019

@keharper keharper self-assigned this Apr 3, 2019

Processing PRs automation moved this from Needs writer approval to Needs testing Apr 8, 2019

@osrecio

osrecio approved these changes Apr 8, 2019

Copy link
Member

left a comment

Now it is ok.

Thanks @atwixfirster :)

atwixfirster added some commits Apr 9, 2019

magento/graphql-ce# Magento_Version module
Merge remote-tracking branch 'upstream/master' into magento-version-module

@atwixfirster atwixfirster changed the title magento/graphql-ce# Magento_Version module magento/graphql-ce# New topic - Check the Magento version Apr 9, 2019

title: Check the Magento version
---

There are the next ways how to get a version of Magento store:

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
There are the next ways how to get a version of Magento store:
Use any of the following ways to determine which version of Magento is installed:

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

fixed

---

There are the next ways how to get a version of Magento store:
- through command line

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
- through command line
- From the command line

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

fixed


There are the next ways how to get a version of Magento store:
- through command line
- through HTTP GET request

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
- through HTTP GET request
- With an HTTP GET request

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

fixed

There are the next ways how to get a version of Magento store:
- through command line
- through HTTP GET request
- from Magento backend (admin account is required)

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
- from Magento backend (admin account is required)
- From within the Magento Admin

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

fixed

- through command line
- through HTTP GET request
- from Magento backend (admin account is required)
- from `composer.lock` file

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
- from `composer.lock` file
- By viewing the `composer.lock` file

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

fixed

```

#### HTTP GET request
HTTP request allows to get a short information about Magento version.

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
HTTP request allows to get a short information about Magento version.
An HTTP request returns less detailed information about the Magento version.

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

implemented

Magento/2.3 (Community)
```

#### Magento backend

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
#### Magento backend
## Magento Admin

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

implemented


#### Magento backend

Login as a registered admin user into back-end side of your Magento store. Then go to the bottom of the page. Magento version will be displayed in the right corner above "Account Activity" and "Report an Issue" links:

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
Login as a registered admin user into back-end side of your Magento store. Then go to the bottom of the page. Magento version will be displayed in the right corner above "Account Activity" and "Report an Issue" links:
Login to Magento as a registered Admin user. The Magento version is displayed at the bottom right of the page, above the **Account Activity** and **Report an Issue** links:

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

implemented


![Check the Magento version]({{ page.baseurl }}/extension-dev-guide/images/version.png)

#### File `composer.lock`

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
#### File `composer.lock`
## The `composer.lock` file

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

fixed

![Check the Magento version]({{ page.baseurl }}/extension-dev-guide/images/version.png)

#### File `composer.lock`
Please note that Magento reads current version from the `composer.lock` file that locates in the root of the store. If you want to get Magento version from this file then make search for `magento/product-community-edition` (if you use community edition) or `magento/product-enterprise-edition` (if you use commerce version):

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor
Suggested change
Please note that Magento reads current version from the `composer.lock` file that locates in the root of the store. If you want to get Magento version from this file then make search for `magento/product-community-edition` (if you use community edition) or `magento/product-enterprise-edition` (if you use commerce version):
Magento reads the current version from the `<Magento_root>/composer.lock` file. To determine the Magento version, search for `magento/product-community-edition` or `magento/product-enterprise-edition`, depending on which version of Magento is installed.

This comment has been minimized.

Copy link
@keharper

keharper Apr 16, 2019

Contributor

Please verify this statement. I don't see any reference to magento/product here:
https://github.com/magento/magento2/blob/2.3-develop/composer.lock

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

Please verify this statement. I don't see any reference to magento/product here:
https://github.com/magento/magento2/blob/2.3-develop/composer.lock

I've verified this step within debug.

This comment has been minimized.

Copy link
@atwixfirster

atwixfirster Apr 16, 2019

Author Contributor

@keharper , all changes have been implemented. 🎉

Could you please review?

Thank you!

Processing PRs automation moved this from Needs testing to Needs writer approval Apr 16, 2019

magento/graphql-ce# New topic - Check the Magento version
1. Implement Kevin’s suggestions

atwixfirster and others added some commits Apr 17, 2019

Processing PRs automation moved this from Needs writer approval to Needs testing Apr 17, 2019

@keharper

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

running tests

@keharper keharper merged commit 6bca4db into magento:master Apr 17, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details

Processing PRs automation moved this from Needs testing to Done Apr 17, 2019

@contribution-survey

This comment has been minimized.

Copy link

commented Apr 17, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Thanks so much for another new topic, @atwixfirster

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@keharper, please add a "whatsnew" description to the end of the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.