Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme inheritance layout files load order - Issue #2796 #4499

Merged
merged 3 commits into from May 12, 2019

Conversation

rodrigowebjump
Copy link
Member

@rodrigowebjump rodrigowebjump commented May 12, 2019

Purpose of this pull request

Fix the topic Extend layouts load XML files order

#2796

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/themes/theme-inherit.html

whatsnew
Updated information for XML file order for Theme inheritance.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 12, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lorikrell
❌ rodrigowebjump

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@lorikrell
Copy link

@rodrigowebjump thanks for your contribution! I will review the content, and continue with running tests, to merge. If I have requests for changes, I'll let you know. 👍

@lorikrell lorikrell self-requested a review May 12, 2019 20:21
@lorikrell lorikrell self-assigned this May 12, 2019
@lorikrell lorikrell added 2.x Contribution Day Issues and PRs for Contribution Days! Groomed and ready to work. Major Update Significant original updates to existing content labels May 12, 2019
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Rodrigo. Looks good!

@lorikrell
Copy link

running tests

@lorikrell lorikrell merged commit b190b14 into magento:master May 12, 2019
@ghost
Copy link

ghost commented May 12, 2019

Hi @rodrigowebjump, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Contribution Day Issues and PRs for Contribution Days! Groomed and ready to work. Major Update Significant original updates to existing content Partner: Webjump partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants