Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product view page available containers #4630

Merged
merged 3 commits into from Jul 8, 2019

Conversation

abrarpathan19
Copy link
Contributor

@abrarpathan19 abrarpathan19 commented May 29, 2019

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

1 similar comment
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@jeff-matthews jeff-matthews added this to Backlog in Processing PRs via automation May 31, 2019
@dobooth
Copy link
Contributor

dobooth commented Jun 3, 2019

Hi @abrarpathan19 Do the checkout and wishlist pages also have available containers that should be listed here?

@dobooth dobooth added the Waiting for Response Waiting for response from internal/external parties label Jun 3, 2019
@abrarpathan19
Copy link
Contributor Author

abrarpathan19 commented Jun 3, 2019

Hi @dobooth the listed container are only for customizing product page design and structure. Whislist page and checkout pages have different containers.

Thanks

@dobooth
Copy link
Contributor

dobooth commented Jun 4, 2019

Hi @abrarpathan19, perhaps I was too vague. If the other pages also have containers, they should be listed here. It doesn't look complete if only one of the three pages has a container list. Please add the other containers to this topic.

@abrarpathan19
Copy link
Contributor Author

Hi @dobooth,

Product page containers are the most important part while product page development. It is very easy to customize design structure while frontend development. This is the magento special features for the provide additional information on the page. That's why I have post this PR.

And checkout and wishlist page there are common containers like other pages.

@abrarpathan19
Copy link
Contributor Author

abrarpathan19 commented Jun 6, 2019

Hi @dobooth,

Product page containers are the most important part while product page development. It is very easy to customize design structure while frontend development. This is the magento special features for the provide additional information on the page. That's why I have post this PR.

And checkout and wishlist page there are common containers like other pages.

Please review Wishlist and checkout layout file there common containers available like other pages :

https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Checkout/view/frontend/layout/catalog_product_view.xml

https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Wishlist/view/frontend/layout/catalog_product_view.xml

@lorikrell lorikrell moved this from Backlog to On Hold in Processing PRs Jun 6, 2019
@abrarpathan19
Copy link
Contributor Author

abrarpathan19 commented Jun 15, 2019

Hi @dobooth, can you please update this PR

2 similar comments
@abrarpathan19
Copy link
Contributor Author

Hi @dobooth, can you please update this PR

@abrarpathan19
Copy link
Contributor Author

Hi @dobooth, can you please update this PR

@abrarpathan19
Copy link
Contributor Author

Hi, @dobooth can you please review this PR also

@keharper keharper added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes labels Jun 27, 2019
Processing PRs automation moved this from On Hold to Needs Jenkins testing Jul 8, 2019
@dobooth dobooth added Major Update Significant original updates to existing content and removed Waiting for Response Waiting for response from internal/external parties labels Jul 8, 2019
@dobooth
Copy link
Contributor

dobooth commented Jul 8, 2019

running tests

@dobooth dobooth merged commit fcd4a82 into magento:master Jul 8, 2019
Processing PRs automation moved this from Needs Jenkins testing to Done Jul 8, 2019
@ghost
Copy link

ghost commented Jul 8, 2019

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@abrarpathan19
Copy link
Contributor Author

@dobooth Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Krish TechnoLabs partners-contribution PR created by Magento partner
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants