Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logging options should match sentence context #5219

Merged
merged 2 commits into from Aug 20, 2019

Conversation

jeff-matthews
Copy link
Contributor

Purpose of this pull request

This pull request (PR) swaps the 1 and 0 options to match the order in which "enable" and "disable" appear in the rest of the sentence.

This issue was reported by Magento Support.

Affected DevDocs pages

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Aug 20, 2019
@jeff-matthews jeff-matthews self-assigned this Aug 20, 2019
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 20, 2019
@jeff-matthews jeff-matthews added 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff and removed Progress: review labels Aug 20, 2019
@jeff-matthews jeff-matthews requested a review from a team August 20, 2019 16:24
@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Aug 20, 2019
@jeff-matthews jeff-matthews removed the request for review from keharper August 20, 2019 17:00
@jeff-matthews
Copy link
Contributor Author

running tests

@jeff-matthews jeff-matthews merged commit 04d2505 into master Aug 20, 2019
@ghost
Copy link

ghost commented Aug 20, 2019

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Aug 20, 2019
@jeff-matthews jeff-matthews deleted the debug-logging branch August 21, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants