Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backward incompatible changes docs for 2.3 #5686

Merged
merged 4 commits into from Oct 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1,6 @@
### {{ site.data.var.ee }} only changes in classes {#ee-class-232-233}

| What changed | How it changed |
| --- | --- |
| Magento\SalesArchive\Block\Adminhtml\Sales\Order\View\Buttons::\_\_construct | [public] Method parameter typing changed. |
| Magento\Rma\Block\Adminhtml\Order\View\Buttons::\_\_construct | [public] Method parameter typing changed. |
53 changes: 53 additions & 0 deletions _includes/backward-incompatible-changes/open-source/2.3.2-2.3.3.md
@@ -0,0 +1,53 @@
### Class changes {#class-232-233}

| What changed | How it changed |
| --- | --- |
| Magento\Framework\Mail\Template\TransportBuilder::getTransport | [public] Method return typing changed. |
| Magento\Framework\Mail\Template\TransportBuilder::getTemplate | [protected] Method return typing changed. |
| Magento\Framework\DataObject\Copy::copyFieldsetToTarget | [public] Method return typing changed. |
| Magento\Framework\Data\Collection\AbstractDb::\_renderFiltersBefore | [protected] Method return typing changed. |
| Magento\Tax\Block\Adminhtml\Rate\Form::\_construct | [protected] Method return typing changed. |
| Magento\Swatches\Block\Product\Renderer\Configurable::getHtmlOutput | [protected] Method return typing changed. |
| Magento\Sales\Model\Order\Config::getStateDefaultStatus | [public] Method return typing changed. |
| Magento\Sales\Model\Order\Config::getStatusFrontendLabel | [public] Method return typing changed. |
| Magento\Sales\Block\Order\History::\_construct | [protected] Method return typing changed. |
| Magento\Sales\Block\Order\History::\_prepareLayout | [protected] Method return typing changed. |
| Magento\Sales\Block\Order\Recent::\_construct | [protected] Method return typing changed. |
| Magento\Sales\Block\Order\Recent::\_toHtml | [protected] Method return typing changed. |
| Magento\Sales\Block\Adminhtml\Order\View::\_\_construct | [public] Method parameter typing changed. |
| Magento\Review\Block\Customer\View::\_toHtml | [protected] Method return typing changed. |
| Magento\Newsletter\Model\Subscriber::received | [public] Method return typing changed. |
| Magento\Newsletter\Block\Adminhtml\Problem::\_construct | [protected] Method return typing changed. |
| Magento\Newsletter\Block\Adminhtml\Problem::getUnsubscribeButtonHtml | [public] Method return typing changed. |
| Magento\Newsletter\Block\Adminhtml\Problem::getDeleteButtonHtml | [public] Method return typing changed. |
| Magento\GraphQl\Controller\GraphQl::dispatch | [public] Method return typing changed. |
| Magento\Config\Console\Command\ConfigSetCommand::execute | [protected] Method return typing changed. |
| Magento\Checkout\Block\Cart\Totals::\_\_construct | [public] Method parameter typing changed. |
| Magento\CatalogRule\Model\Indexer\IndexBuilder::getActiveRules | [protected] Method return typing changed. |
| Magento\CatalogRule\Model\Indexer\IndexBuilder::getAllRules | [protected] Method return typing changed. |
| Magento\Catalog\Model\ResourceModel\Product::getCategoryCollection | [public] Method return typing changed. |
| Magento\Catalog\Model\Product\Visibility::getVisibleInCatalogIds | [public] Method return typing changed. |
| Magento\Catalog\Model\Product\Visibility::getVisibleInSearchIds | [public] Method return typing changed. |
| Magento\Catalog\Model\Product\Visibility::getVisibleInSiteIds | [public] Method return typing changed. |
| Magento\Catalog\Block\Adminhtml\Product\Grid::\_construct | [protected] Method return typing changed. |
| Magento\Catalog\Block\Adminhtml\Product\Grid::\_prepareCollection | [protected] Method return typing changed. |
| Magento\Catalog\Block\Adminhtml\Product\Grid::\_addColumnFilterToCollection | [protected] Method return typing changed. |
| Magento\Catalog\Block\Adminhtml\Product\Grid::\_prepareColumns | [protected] Method return typing changed. |
| Magento\Catalog\Block\Adminhtml\Product\Grid::\_prepareMassaction | [protected] Method return typing changed. |
| Magento\Catalog\Block\Adminhtml\Product\Grid::getGridUrl | [public] Method return typing changed. |
| Magento\Catalog\Block\Adminhtml\Product\Grid::getRowUrl | [public] Method return typing changed. |
| Magento\Backend\Block\Store\Switcher::\_construct | [protected] Method return typing changed. |
| Magento\Wishlist\Model\ResourceModel\Item\Collection::\_renderFiltersBefore | [protected] Method has been added. |
| Magento\Sales\Model\Order\Address::beforeSave | [public] Method has been added. |
| Magento\Reports\Block\Adminhtml\Grid::\_\_construct | [public] Method has been added. |
| Magento\PageCache\Model\Config::VARNISH\_6\_CONFIGURATION\_PATH | Constant has been added. |
| Magento\Eav\Model\ResourceModel\Entity\Attribute::\_beforeDelete | [protected] Method has been added. |
| Magento\Directory\Model\ResourceModel\Country::\_\_construct | [public] Method has been added. |
| Magento\Backend\Model\Url::setScope | [public] Method has been added. |

### Interface changes {#interface-232-233}

| What changed | How it changed |
| --- | --- |
| Magento\Vault\Api\PaymentTokenManagementInterface::getListByCustomerId | [public] Method return typing changed. |

Expand Up @@ -9,7 +9,13 @@ redirect_from:
The changes are aggregated into two tables:

1. **Changes in classes** that contains backward incompatible changes made to the PHP classes
2. **Changes in interfaces** that contains backward incompatible changes made to the PHP interfaces
1. **Changes in interfaces** that contains backward incompatible changes made to the PHP interfaces

## 2.3.2 - 2.3.3

{% include backward-incompatible-changes/open-source/2.3.2-2.3.3.md %}

{% include backward-incompatible-changes/commerce/2.3.2-2.3.3.md %}

## 2.3.1 - 2.3.2

Expand Down