Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Page: Form Validation #6226

Merged
merged 8 commits into from Dec 19, 2019
Merged

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Dec 18, 2019

Purpose of this pull request

This pull request (PR) creates a new page under Frontend Developer Guide to describe the files and structure of the form validation modules present in Magento.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added a new Form Validation topic to the Frontend Developer Guide.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Dec 18, 2019
@rogyar rogyar self-assigned this Dec 19, 2019
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Dec 19, 2019
@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document labels Dec 19, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @drpayyne! Just a few minor editorial suggestions and I think this will be ready to merge.

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
@keharper
Copy link
Contributor

@drpayyne Don't forget to add these lines to the frontmatter

contributor_name:
contributor_link:

@drpayyne
Copy link
Contributor Author

On it, @keharper and @jeff-matthews. Thanks!

drpayyne and others added 3 commits December 19, 2019 21:25
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drpayyne!

@drpayyne
Copy link
Contributor Author

Thank you, @jeff-matthews!

@jeff-matthews jeff-matthews moved this from Changes Requested to Reviewer Approved in Pull Request Progress Dec 19, 2019
@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews
Copy link
Contributor

Tests failed on linting errors:

+ rake test:md
�[35mTesting Markdown style with mdl ...�[0m
�[31mThe Markdown linter detected 4 issue(s)�[0m
�[33msrc/guides/v2.2/frontend-dev-guide/validations/form-validation.md:15: MD001 Header levels should only increment by one level at a time
src/guides/v2.2/frontend-dev-guide/validations/form-validation.md:21: MD009 Trailing spaces
src/guides/v2.3/frontend-dev-guide/validations/form-validation.md:15: MD001 Header levels should only increment by one level at a time
src/guides/v2.3/frontend-dev-guide/validations/form-validation.md:21: MD009 Trailing spaces

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

@drpayyne
Copy link
Contributor Author

@jeff-matthews, on it.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed it @drpayyne

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit ed2fbcb into magento:master Dec 19, 2019
@ghost
Copy link

ghost commented Dec 19, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Partner: Zilker Technology partners-contribution PR created by Magento partner
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants