New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix env.php code sample for message queue configuration #7896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provided code snippet is an example of final queue configuration.
Here is a part that relates only to switching from mysql to amqp for "product_action_attribute.update" queue:
'topics' => [
'product_action_attribute.update' => [
'publisher' => 'amqp-magento'
]
],
'config' => [
'publishers' => [
'product_action_attribute.update' => [
'connections' => [
'amqp' => [
'name' => 'amqp',
'exchange' => 'magento',
'disabled' => false
],
'db' => [
'name' => 'db',
'disabled' => true
]
]
]
]
],
'consumers' => [
'product_action_attribute.update' => [
'connection' => 'amqp',
],
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is named "Override topic configuration", but contains information only about switching from mysql to amqp. As for now we don't have more information about overriding other parameters, I suggest renaming this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the old config sample (lines 55-78)
running tests |
Hi @jeff-matthews, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) fixes an invalid
env.php
code sample for message queue configuration.See internal ticket MC-32147 for details.
Affected DevDocs pages
whatsnew
Fixed invalid
env.php
code sample for message queue configuration.