Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env.php code sample for message queue configuration #7896

Merged
merged 4 commits into from Oct 12, 2020

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Sep 17, 2020

Purpose of this pull request

This pull request (PR) fixes an invalid env.php code sample for message queue configuration.

See internal ticket MC-32147 for details.

Affected DevDocs pages

whatsnew
Fixed invalid env.php code sample for message queue configuration.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Sep 17, 2020
@jeff-matthews jeff-matthews added 2.3.6 Technical Updates to the code or processes that alter the technical content of the doc labels Sep 17, 2020
@jeff-matthews jeff-matthews changed the title Fox env.php code sample for message queue configuration Fix env.php code sample for message queue configuration Sep 17, 2020
Pull Request Progress automation moved this from Ready for Review to Reviewer Approved Sep 22, 2020
Copy link
Contributor

@dhorytskyi dhorytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet is an example of final queue configuration.
Here is a part that relates only to switching from mysql to amqp for "product_action_attribute.update" queue:

'topics' => [
    'product_action_attribute.update' => [
        'publisher' => 'amqp-magento'
    ]
],
'config' => [
    'publishers' => [
        'product_action_attribute.update' => [
            'connections' => [
                'amqp' => [
                    'name' => 'amqp',
                    'exchange' => 'magento',
                    'disabled' => false
                ],
                'db' => [
                    'name' => 'db',
                    'disabled' => true
                ]
            ]
        ]
    ]
],
'consumers' => [
    'product_action_attribute.update' => [
        'connection' => 'amqp',
    ],
],

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Sep 22, 2020
Copy link
Contributor

@dhorytskyi dhorytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is named "Override topic configuration", but contains information only about switching from mysql to amqp. As for now we don't have more information about overriding other parameters, I suggest renaming this section.

@dobooth dobooth self-requested a review October 1, 2020 14:48
Pull Request Progress automation moved this from Review in Progress to Reviewer Approved Oct 1, 2020
@dobooth
Copy link
Contributor

dobooth commented Oct 12, 2020

@dhorytskyi

Copy link
Contributor

@dhorytskyi dhorytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the old config sample (lines 55-78)

@jeff-matthews
Copy link
Contributor Author

running tests

@jeff-matthews jeff-matthews merged commit a6d4714 into 2.4.1-develop Oct 12, 2020
@ghost
Copy link

ghost commented Oct 12, 2020

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jeff-matthews jeff-matthews deleted the MC-32147-mq-config branch October 12, 2020 20:16
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.3.6 Technical Updates to the code or processes that alter the technical content of the doc
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants