-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEL: doc section related to enable_lazy_loading_for_images_without_borders #7928
DEL: doc section related to enable_lazy_loading_for_images_without_borders #7928
Conversation
An admin must run tests on this PR before it can be merged. |
Since the code PR hasn't been merged yet, we can't merge this doc PR. I'm guessing that the code PR will be merged for the 2.4.2 release. If that's true, then this Pr will need to be rebased onto the |
@GrimLink So if this is indeed for 2.4.2, it should be rebased here. |
@dobooth I have changed the target branch to 2.4.2-develop. @jeff-matthews The PR has been merged for the 2.4.2 release -> magento/magento2#30186 (comment) |
@BarnyShergold Can you please look at line 185? It seems to want to say "outside of the defined module", or rather "outside of the module in which it is defined." |
@BarnyShergold wille I agree. This PR is purely for the removal of a section for a feature that is going to be removed in Magento 2.4.2 |
Regarding PR scope creep, I do advocate keeping within scope. |
@hguthrie - Okay if that is the general practise, I'll go with this - we should therefore consider this PR reviewed and passed - thanks for the feedback |
It is the general practice, although we discourage tiny updates, like a single spelling correction, because it does create unnecessary overhead. For things like that, it is better to group those changes in a single PR. |
running tests |
Hi @GrimLink, thank you for your contribution! |
Purpose of this pull request
Removes the docs related to the option
enable_lazy_loading_for_images_without_borders
.This section is not needed anymore when PR magento/magento2#30139 is merged.
For info on why and how.
Please read the related PR.
Affected DevDocs pages
Links to Magento source code
See the PR for the changed files: