Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEL: doc section related to enable_lazy_loading_for_images_without_borders #7928

Merged
merged 2 commits into from
Oct 1, 2020
Merged

DEL: doc section related to enable_lazy_loading_for_images_without_borders #7928

merged 2 commits into from
Oct 1, 2020

Conversation

GrimLink
Copy link
Member

Purpose of this pull request

Removes the docs related to the option enable_lazy_loading_for_images_without_borders.
This section is not needed anymore when PR magento/magento2#30139 is merged.

For info on why and how.
Please read the related PR.

Affected DevDocs pages

Links to Magento source code

See the PR for the changed files:

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Sep 23, 2020
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

Pull Request Progress automation moved this from Ready for Review to Reviewer Approved Sep 24, 2020
@jeff-matthews
Copy link
Contributor

Since the code PR hasn't been merged yet, we can't merge this doc PR. I'm guessing that the code PR will be merged for the 2.4.2 release. If that's true, then this Pr will need to be rebased onto the 2.4.2-develop branch.

@jeff-matthews jeff-matthews added 2.4.2 Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Sep 25, 2020
@dobooth
Copy link
Contributor

dobooth commented Sep 29, 2020

@GrimLink So if this is indeed for 2.4.2, it should be rebased here.

@GrimLink GrimLink changed the base branch from master to 2.4.2-develop September 30, 2020 06:39
@GrimLink
Copy link
Member Author

GrimLink commented Sep 30, 2020

@dobooth I have changed the target branch to 2.4.2-develop.

@jeff-matthews The PR has been merged for the 2.4.2 release -> magento/magento2#30186 (comment)

@dobooth
Copy link
Contributor

dobooth commented Sep 30, 2020

@BarnyShergold Can you please look at line 185? It seems to want to say "outside of the defined module", or rather "outside of the module in which it is defined."

@BarnyShergold
Copy link
Contributor

@dobooth - Good spot, that line doesn't make sense even before the changes.

IMO I think it may also be trying to say "Variables may be used within the scope of modules other than the defined one"?

What do you think @GrimLink ?

@GrimLink
Copy link
Member Author

@BarnyShergold wille I agree.
And your suggestion makes this line better.
This should be its own PR.

This PR is purely for the removal of a section for a feature that is going to be removed in Magento 2.4.2

@BarnyShergold
Copy link
Contributor

Like code if we spot an error in a file we are modifying in docs we should simply fix it.

Otherwise, someone will have to create another PR and go through the whole process when it would take 5 mins to reword on this PR.

@hguthrie @meker12 - What's the opinion of the Docs team?

@hguthrie
Copy link
Contributor

hguthrie commented Oct 1, 2020

Regarding PR scope creep, I do advocate keeping within scope.
However, it is at the Author's discretion, if they feel comfortable, to make the additional change...as long as it is clearly noted in the PR description.

@BarnyShergold
Copy link
Contributor

@hguthrie - Okay if that is the general practise, I'll go with this - we should therefore consider this PR reviewed and passed - thanks for the feedback

@hguthrie
Copy link
Contributor

hguthrie commented Oct 1, 2020

@hguthrie - Okay if that is the general practise, I'll go with this - we should therefore consider this PR reviewed and passed - thanks for the feedback

It is the general practice, although we discourage tiny updates, like a single spelling correction, because it does create unnecessary overhead. For things like that, it is better to group those changes in a single PR.

@keharper
Copy link
Contributor

keharper commented Oct 1, 2020

running tests

@hguthrie hguthrie merged commit 8732cac into magento:2.4.2-develop Oct 1, 2020
@ghost
Copy link

ghost commented Oct 1, 2020

Hi @GrimLink, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Oct 1, 2020
@GrimLink GrimLink deleted the bugfix/wrong-size-attributes-in-image_with_border branch October 1, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.2 Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants