Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description for issue 28239 fix #9084

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Add description for issue 28239 fix #9084

merged 4 commits into from
Aug 24, 2021

Conversation

mozok
Copy link
Contributor

@mozok mozok commented Aug 11, 2021

In General fixes add description for magento/magento2#28239
PR magento/magento2#33452

Purpose of this pull request

Update M2.4.3 release notes.

Affected DevDocs pages

Links to Magento source code

BarnyShergold
BarnyShergold suggested changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar correction.

src/guides/v2.4/release-notes/open-source-2-4-3.md Outdated Show resolved Hide resolved
@mozok
Update src/guides/v2.4/release-notes/open-source-2-4-3.md
3acb22c 
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
@dobooth dobooth requested a review from jfrontain August 11, 2021 15:44
@dobooth dobooth added 2.4.3 Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Aug 19, 2021
@dobooth
Copy link
Contributor

dobooth commented Aug 19, 2021

@magento import pr to magento-devdocs/devdocs

@magento-engcom-team
Copy link

@dobooth the pull request successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit ee1ed64 into magento:master Aug 24, 2021
@ghost
Copy link

ghost commented Aug 24, 2021

Hi @mozok, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

mozok added a commit to mozok/devdocs that referenced this pull request Aug 24, 2021
@mozok
Update engcomm-2-4-3-issues.md
27b1fb1 
Update individual contributor list according to magento#9084
@mozok mozok mentioned this pull request Aug 24, 2021
Closed
@mozok
Copy link
Contributor Author

mozok commented Aug 25, 2021

@BarnyShergold @dobooth Hi.
This PR has mistake. Referred fix (magento/magento2#33452) was merged before release, but was not included in 2.4.3 release tag. It turns out I've mistakenly added information about fix on release page.
Also this comment magento/magento2#28239 (comment) not quite true.

Should I create new PR to remove wrong info, or create revert of current PR?

@Den4ik
Copy link
Contributor

Den4ik commented Aug 25, 2021

@gabrieldagama Could you explain why magento/magento2#33452 not released with 2.4.3?

@mozok
Copy link
Contributor Author

mozok commented Aug 25, 2021

Also I was noted, that there is no changes in https://github.com/magento/magento2/blob/2.4.3/app/code/Magento/MediaStorage/Console/Command/ImagesResizeCommand.php
associated with https://github.com/magento/magento2/pull/33452/files

@gabrieldagama
Copy link
Contributor

@gabrieldagama Could you explain why magento/magento2#33452 not released with 2.4.3?

This was merged 27 days ago. Internally we have had branch cut off before that, this is necessary for the regression process. It will be released on 2.4.4.

@Den4ik
Copy link
Contributor

Den4ik commented Aug 25, 2021

Thanks for information. @mozok i think we should revert this commit

@mozok
Copy link
Contributor Author

mozok commented Aug 25, 2021

@Den4ik ok
I don't see usual 'Revert' option near commit message #9084 (comment)
Should I create new PR and delete text, that was added in this PR?

@Den4ik
Copy link
Contributor

Den4ik commented Aug 25, 2021

@mozok Yep, I mean create PR with revert commit

@mozok mozok mentioned this pull request Aug 26, 2021
Merged
@mozok
Copy link
Contributor Author

mozok commented Aug 26, 2021

@Den4ik thank you for assist
Here is the PR #9112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@BarnyShergold BarnyShergold BarnyShergold approved these changes

@dobooth dobooth dobooth approved these changes

@jfrontain jfrontain Awaiting requested review from jfrontain

Assignees

@Den4ik Den4ik

@BarnyShergold BarnyShergold

@dobooth dobooth

Labels
2.4.3 Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Progress: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mozok @dobooth @magento-engcom-team @Den4ik @gabrieldagama @BarnyShergold @magento-devops-reposync-svc