Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

magento/graphql-ce#: [Test coverage]. Mutation: applyCouponToCart. Cover exception - Required parameter "coupon_code" is missing #1077

Merged
merged 1 commit into from Dec 18, 2019
Merged

magento/graphql-ce#: [Test coverage]. Mutation: applyCouponToCart. Cover exception - Required parameter "coupon_code" is missing #1077

merged 1 commit into from Dec 18, 2019

Conversation

atwixfirster
Copy link
Contributor

Description (*)

PR provides test coverage for the Required parameter "coupon_code" is missing exception.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@atwixfirster
magento/graphql-ce#: [Test coverage]. applyCouponToCart. Cover except…
e5b7272 
…ion - Required parameter "coupon_code" is missing
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Dec 16, 2019
@atwixfirster atwixfirster changed the title magento/graphql-ce#: [Test coverage]. applyCouponToCart. Cover exception - Required parameter "coupon_code" is missing magento/graphql-ce#: [Test coverage]. Mutation: applyCouponToCart. Cover exception - Required parameter "coupon_code" is missing Dec 16, 2019
@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Dec 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6493 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team magento-engcom-team merged commit e5b7272 into 2.3-develop Dec 18, 2019
magento-engcom-team pushed a commit that referenced this pull request Dec 18, 2019
@lenaorobei
ENGCOM-6493: magento/graphql-ce#: [Test coverage]. Mutation: applyCou…
7a60cbf 
…ponToCart. Cover exception - Required parameter "coupon_code" is missing #1077
@ghost
Copy link

ghost commented Dec 18, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Dec 18, 2019
@okorshenko okorshenko deleted the test-coverage-applyCouponToCart branch December 18, 2019 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered Award: test coverage Partner: Atwix partners-contribution Release Line: 2.3
Projects
Pull Request Progress
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atwixfirster @magento-engcom-team @lenaorobei