This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
[Checkout] Prevent generating new masked quote id for same quote #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit prevents the `createEmptyCart` mutation from generating a new masked quote id for the same customer quote. Fixes magento#773
lenaorobei
reviewed
Aug 5, 2019
| ) { | ||
| $this->cartManagement = $cartManagement; | ||
| $this->quoteIdMaskFactory = $quoteIdMaskFactory; | ||
| $this->quoteIdMaskResourceModel = $quoteIdMaskResourceModel; | ||
| $this->quoteIdToMaskedQuoteId = $quoteIdToMaskedQuoteId ?? ObjectManager::getInstance() |
There was a problem hiding this comment.
This is redundant here. We need to keep BC fro schema only.
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
lenaorobei
approved these changes
Aug 5, 2019
|
Hi @lenaorobei, thank you for the review.
|
lenaorobei
approved these changes
Aug 12, 2019
|
Hi @lenaorobei, thank you for the review. |
|
Hi @pmclain, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 13, 2019
m2-community-project
bot
moved this from Review in Progress
to Done
in Pull Request Progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This commit prevents the
createEmptyCartmutation from generating a new masked quote id for the same customer quote.Fixed Issues
Manual testing scenarios (*)
Follow the steps to reproduce outlined in #773
The result of
createEmptyCartshould be unique per quote and not per request.Contribution checklist (*)