Tests for MSI-1580: For configurable reservation after cancel order isn't create #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sn't create (integration tests on default stock)
…sn't create (integration tests on not default stock)
maghamed
approved these changes
Aug 31, 2018
naydav
suggested changes
Aug 31, 2018
| use Magento\Catalog\Model\Product\Visibility; | ||
| use Magento\TestFramework\Helper\Bootstrap; | ||
|
|
||
| Bootstrap::getInstance()->reinitialize(); |
There was a problem hiding this comment.
Why do we need reinitialize? Looks like copy paste
There was a problem hiding this comment.
@naydav Without reinitialize test in scope run are failed. I'm copy it from other test
| /** @var $objectManager \Magento\TestFramework\ObjectManager */ | ||
| $objectManager = Bootstrap::getObjectManager(); | ||
| /** @var ProductRepositoryInterface $productRepository */ | ||
| $productRepository = $objectManager->create(ProductRepositoryInterface::class); |
There was a problem hiding this comment.
You need to use get method instead of create
| @@ -0,0 +1,50 @@ | |||
| <?php | |||
There was a problem hiding this comment.
You can reuse existed fixture (new inventory modules)
| use Magento\Catalog\Model\Product\Visibility; | ||
| use Magento\GroupedProduct\Model\Product\Type\Grouped; | ||
| use Magento\TestFramework\Helper\Bootstrap; | ||
| use Magento\Store\Model\Website; |
There was a problem hiding this comment.
Try to work with API interfaces anywhere if it is possible
| @@ -0,0 +1,89 @@ | |||
| <?php | |||
There was a problem hiding this comment.
We already have similar fixture (new inventory fixtures)
|
code review changes to PR should be done, especially regarding test coverage |
4 tasks
maghamed
changed the title
|
Closing this PR for now as it's very outdated and conflicting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get sku for reservation from order item.
Fixed Issues (if relevant)
Contribution checklist