MSI-2043: disabled source selection when disabled manage stock

[VitaliyBoyko]

Description

Disabled source selection algorithm when managing stock is disabled.

Fixed Issues (if relevant)

1. Cannot create shipment: Source item not found by source code: default and sku: [my-sku custom option] #2043: Cannot create shipment: Source item not found by source code: default and SKU: [my-sku custom option]

Manual testing scenarios

1

1. Create multiple sources and stocks
2. Create a product and assign it to the custom sources.
3. Disable stock managing Stores > Configuration > Catalog > Inventory > Product Stock Options > Manage Stock
4. Create an order with the product
5. Create and submit a shipment
   SSA page shouldn't be shown.

2

1. Create multiple sources and stocks
2. Create a product and assign it to the custom sources.
3. Disable stock managing for Product via Advanced Inventory
4. Create an order with the product
5. Create and submit a shipment
   SSA page shouldn't be shown.

3

1. Create multiple sources and stocks
2. Create 2 products and assign them to the custom sources.
3. Disable stock managing for 1 Product via Advanced Inventory
4. Create an order with both products
5. SSA page should be shown.
   The issue with select sources for this scenario fixed in the scope of MSI-1912: Get sku from order configurable product with custom options #2012.

[adarshkhatri]

I think we need to check this:

        if (!$this->stockConfiguration->getManageStock()) {
            return;
        }

for each product, instead of entire site.

[VitaliyBoyko]

Seems like we have to implement service which will check if the order has at least one stock manageable item. And show SSA according to result. And on SSA level we have to add the check whether item stock manageable or not. @maghamed I'm right?

[maghamed]

@VitaliyBoyko not sure that we need to introduce a dedicated service for these purposes.
Just okay to introduce dedicated class which would use InventoryConfiguration inside

[adarshkhatri]

It looks like there is check in place:

        if (!$stockItemConfiguration->isManageStock()) {
            //We don't need to Manage Stock
            continue;
        }

https://github.com/magento-engcom/msi/blob/2.3-develop/app/code/Magento/InventorySourceDeductionApi/Model/SourceDeductionService.php#L76

I think solution would be to find the list by product id instead of sku. I see that when creating order Magento adds Custom Option to the configurable item, when it has custom option

For example:
Config item's sku: Config Item with Custom Option
Child Item: Config Item with Custom Option-Black-First

But when order created:

Because of this, system will never find the product.

   //namespace Magento\InventorySourceDeductionApi\Model\GetSourceItemBySourceCodeAndSku

    $searchCriteria = $this->searchCriteriaBuilder
        ->addFilter(SourceItemInterface::SOURCE_CODE, $sourceCode) //default
        ->addFilter(SourceItemInterface::SKU, $sku) //Config Item with Custom Option-Black-First Custom Option
        ->create();
    $sourceItemsResult = $this->sourceItemRepository->getList($searchCriteria);

I think, finding the source item by product id will always find the product if it exist.

[malesh-v]

I've checked the first case, I click Ship and SSA page isn't showing(as expected) but if a click Back SSA page loads.

[VitaliyBoyko]

Hi @ishakhsuvarov
I've added the mentioned changes.
Thank you!

[ghost]

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.