MAGECLOUD-3605: Added support for configuring hooks locally via .magento.app.yaml #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BaDos
requested review from
oshmyheliuk,
NadiyaS,
bbatsche,
billygilbert and
michaelcasey316
NadiyaS
approved these changes
Jul 18, 2019
shiftedreality
approved these changes
Jul 18, 2019
kandy
reviewed
Jul 19, 2019
| @@ -0,0 +1,62 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
What the reason to write hooks on python?
There was a problem hiding this comment.
@kandy Because this is an infrastructure part and I think that the infrastructure part must be isolated.
We cannot use, for example, PHP because a user can disable yaml extension.
BaDos
changed the title
|
QA Approved |
mveeramneni
added
Progress: accept
mmansoor-magento
pushed a commit
that referenced
this pull request
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for configuring hooks locally via .magento.app.yaml
Fixed Issues (if relevant)
https://magento2.atlassian.net/browse/MAGECLOUD-3605
Manual testing scenarios
https://jira.corp.magento.com/browse/MAGECLOUD-132
Contribution checklist