Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pound.cfg file and TimeOut and RewriteLocation directives in cfg #37

Merged
merged 2 commits into from Aug 15, 2019

Conversation

sorinsugar
Copy link
Contributor

Description

I've moved the pound.cfg file to this repo and added the following directives as configurable variables: TimeOut and RewriteLocation.
These are added as ENV variables inside the docker files (to provide default values) and the values can be controlled from docker-compose if needed.

Fixed Issues (if relevant)

  1. Magento timeout if the request TTFB takes more than 15 seconds (default value for pound proxy)
  2. Pound proxy rewrites location by default to the request URL so it breaks redirects to outside websites (eg external SSO)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@magento-cicd2
Copy link

magento-cicd2 commented Aug 9, 2019

CLA assistant check
All committers have signed the CLA.

@YPyltiai YPyltiai added the Progress: review PR/issue status label Aug 12, 2019
@shiftedreality
Copy link
Member

@sorinsugar thank you for your submission! We are review and process it.

@shiftedreality
Copy link
Member

@sorinsugar could you please merge latest changes and resolve conflict? We're about to pick it up for QA

@sorinsugar
Copy link
Contributor Author

@shiftedreality I've merged the latest master into my PR.

@andriyShevtsov
Copy link
Contributor

Created internal task https://magento2.atlassian.net/browse/MAGECLOUD-4095

@andriyShevtsov
Copy link
Contributor

QA approved

@shiftedreality shiftedreality added the Progress: accept PR/issue status label Aug 15, 2019
@shiftedreality shiftedreality merged commit e4ee694 into magento:master Aug 15, 2019
@YPyltiai YPyltiai added Release: 1.0.0 Magento-Cloud-Docker Release and removed Progress: testing in progress labels Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community PR/issue origin improvement issue type Progress: accept PR/issue status Release: 1.0.0 Magento-Cloud-Docker Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants