Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] Forbid overriding built-in objects #359

Merged

Conversation

fredden
Copy link
Member

@fredden fredden commented Jan 11, 2022

This is a small part of #347 as suggested in #347 (comment).

https://eslint.org/docs/rules/no-global-assign

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jan 11, 2022
@fredden fredden changed the title Forbid overriding built-in objects [eslint] Forbid overriding built-in objects Mar 28, 2023
@sidolov
Copy link
Collaborator

sidolov commented Sep 20, 2023

@magento import PR to magento-commerce/magento-coding-standard repository

@m2-github-services
Copy link
Contributor

@sidolov the Pull Request is successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit c8ce5be into magento:develop Sep 20, 2023
@m2-community-project m2-community-project bot moved this from Ready for Review to Done in Pull Request Progress Sep 20, 2023
@fredden fredden deleted the eslint-no-global-assign branch September 20, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants