Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE-1288: ModuleResolver test paths are too greedy #244

Merged
merged 3 commits into from Oct 5, 2018
Merged

MQE-1288: ModuleResolver test paths are too greedy #244

merged 3 commits into from Oct 5, 2018

Conversation

aljcalandra
Copy link
Contributor

Modified Module Resolver to restrict search areas for MFTF Tests

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@aljcalandra
MQE-1288: ModuleResolver test paths are too greedy
dda214e 
- Specify to onnly look under app and vendor for magento bp
- Removed Project root from list of search areas
@aljcalandra
MQE-1288: ModuleResolver test paths are too greedy
17fd97b 
- Fixed Empty space and unused comma
@coveralls
Copy link

coveralls commented Oct 4, 2018 •
edited

Coverage Status

Coverage decreased (-0.08%) to 57.44% when pulling 3845479 on MQE-1288 into 0a3ef3a on develop.

jilu1
jilu1 approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/Magento/FunctionalTestingFramework/Util/ModuleResolver.php Show resolved Hide resolved
@KevinBKozan KevinBKozan merged commit 528387d into develop Oct 5, 2018
@KevinBKozan KevinBKozan deleted the MQE-1288 branch November 6, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aljcalandra @coveralls @jilu1 @KevinBKozan