Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pangolin] Deliver changes to mainline framework repo #4

Merged
merged 3 commits into from
Sep 29, 2017
Merged

[Pangolin] Deliver changes to mainline framework repo #4

merged 3 commits into from
Sep 29, 2017

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Sep 28, 2017

Scope

Story

  • MQE-376 [Framework] Resolve selector1 and selector2 replacements in ActionObject
  • MQE-353 [Generator] Remove double curly braces from parameterized data references.
  • MQE-292 Use "selector" name consistently instead of "locator"

Related Pull Request

https://github.com/magento-pangolin/magento2ce/pull/8 - internal
https://github.com/magento/magento2ce/pull/1531 - mainline

…ActionObject

Added selector1 and selector2 to array.
…ta references.

* MQE-353

CAP changes, along with exception bugfix found in last spring demo.

* MQE-353 CR

Changed ternary to be included in parent if.
* MQE-292

Renamed locator to selector where applicable (schema, objects, and handlers).
Also removed locatorVariables element from schema, as it was deprecated by parameterized url/selector implementation.

* MQE-292

Codesniffer fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants