Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pangolin] Deliver changes after MFTF training feedback #5

Merged
merged 23 commits into from
Oct 6, 2017
Merged

[Pangolin] Deliver changes after MFTF training feedback #5

merged 23 commits into from
Oct 6, 2017

Conversation

okolesnyk
Copy link
Member

@okolesnyk okolesnyk commented Oct 6, 2017 •
edited
Loading

Scope

Stories

Related Pull Requests

https://github.com/magento/magento2ee/pull/739
https://github.com/magento/magento2ce/pull/1560

Created by : @tomreece
Internal PR: https://github.com/magento-pangolin/magento2-functional-testing-framework/pull/14

jilu1 and others added 22 commits September 15, 2017 16:38
@jilu1
MQE-326: allow data persistence to custom stores.
7669e57
@jilu1
MQE-369: Implement non web api data persistence.
596f419
@KevinBKozan
MQE-376
36bc43c 
Added selector1 and selector2 to array.
@KevinBKozan @jilu1
MQE-359
3ef29c8 
Removed addslashes, added replace of " to \" since " is read in a " via the xml parser.

(cherry picked from commit c7c7bc9)
@KevinBKozan @jilu1
MQE-359
05190b1 
Removed addslashes, added replace of " to \" since " is read in a " via the xml parser.
Rename wrapWithSingleQuotes to wrapWithDoubleQuotes, and fixed PHP Doc for the function.

(cherry picked from commit 1f81574)
@jilu1
MQE-369: Implement non web api data persistence.
423534c
@jilu1
Merge remote-tracking branch 'origin/sprint-develop' into MQE-326-mul…
97bd6b8 
…ti-stores

# Conflicts:
#	src/Magento/FunctionalTestingFramework/DataGenerator/Api/ApiExecutor.php
#	src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/JsonDefinitionObjectHandler.php
#	src/Magento/FunctionalTestingFramework/DataGenerator/Objects/DataElement.php
#	src/Magento/FunctionalTestingFramework/DataGenerator/Util/JsonObjectExtractor.php
#	src/Magento/FunctionalTestingFramework/Util/TestGenerator.php
@jilu1
Resolve merge conflicts: Merge remote-tracking branch 'origin/sprint-…
93e5768 
…develop' into MQE-326-multi-stores

    # Conflicts:
    #       src/Magento/FunctionalTestingFramework/DataGenerator/Api/ApiExecutor.php
    #       src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/JsonDefinitionObjectHandler.php
    #       src/Magento/FunctionalTestingFramework/DataGenerator/Objects/DataElement.php
    #       src/Magento/FunctionalTestingFramework/DataGenerator/Util/JsonObjectExtractor.php
    #       src/Magento/FunctionalTestingFramework/Util/TestGenerator.php
@KevinBKozan
MQE-353
5ee9070 
* MQE-353

CAP changes, along with exception bugfix found in last spring demo.

* MQE-353 CR

Changed ternary to be included in parent if.
@KevinBKozan
MQE 292 (#8)
4c3acb4 
* MQE-292

Renamed locator to selector where applicable (schema, objects, and handlers).
Also removed locatorVariables element from schema, as it was deprecated by parameterized url/selector implementation.

* MQE-292

Codesniffer fixes.
@jilu1
MQE-369:[Data Input] Non Web Api Data Persistence.
ee3508c
@KevinBKozan
MQE-392: Generated code is incorrect if there is a space between para…
f9dd74a 
…meters

- Added trim to parameter processing to prevent erroneous spaces.
@KevinBKozan
MQE-393: [XML Parser] waitForLoadingMaskToDisppear usage causes parse…
9010ab1 
…r Error

- Added waitForLoadingMaskToDisappear to di.xml
@jilu1
Merge remote-tracking branch 'origin/MQE-326-multi-stores' into sprin…
6932b13 
…t-develop
@jilu1
Merge branch 'sprint-develop' of https://github.com/magento-pangolin/…
baef8f0 
…magento2-functional-testing-framework into sprint-develop
@imeron2433
MQE-309:[Customizability] Update nested API dependency schema and exe…
ad8cad9 
…cution

    - change test schema for simpler persisted entity relationships
    - change data persistence handler to resolve entity relationships
    - change data schema to allow var declaration as a placehold for persisted data
@imeron2433
MQE-309:[Customizability] Update nested API dependency schema and exe…
cef0e3a 
…cution

- remove old entity test schema declarations
@KevinBKozan
MQE-391: Variable is not correctly resolved when array symbol ([ or ]…
8b873a8 
…) is inside $$ signs

- Updated Regex for persisted variable replacement.
@KevinBKozan
MQE-414: [XML Parser] PageObject/SectionObject picking up SampleTempl…
72dab13 
…ates

- Edited di.xml to use Module instead of Mask for Pages/Sections.
@KevinBKozan
MQE-410: [Generator] Bad output with Parameterized Persisted Unique data
3ba4a6d 
- Changed selector resolution to call uniquenessFunctionCall. Solves issue with safe backwards compatibility.
- Generator was stripping ' from selector strings like: #'{{name}}', turning that into #{{name}} when resolved.
@okolesnyk
MQE-424: Fix static code issues in MFTF tests and MFTF
e12f672
@KevinBKozan
MQE-403: Cannot use multiple actionGroups in Test
a0f3637 
- di.xml update, turns out there's way more wrong here than just di.xml
- Changed CAP to append actiongroup Mergekey to steps when processing ActionGroups, otherwise the CAP would find duplicate keys and overwrite them (since the ActionGroup steps technically had the same keys).
@okolesnyk okolesnyk merged commit f077fc9 into magento:develop Oct 6, 2017
@Cristian101 Cristian101 mentioned this pull request Feb 15, 2018
Closed
@rajateshr rajateshr mentioned this pull request Jul 14, 2020
Closed
@Manjula-kalyan Manjula-kalyan mentioned this pull request May 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@okolesnyk @magento-cicd2 @jilu1 @KevinBKozan @imeron2433