Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-691: Fix Waits In PWA MFTF MagentoPwaWebDriver #742

Merged
merged 6 commits into from Jun 17, 2020
Merged

PWA-691: Fix Waits In PWA MFTF MagentoPwaWebDriver #742

merged 6 commits into from Jun 17, 2020

Conversation

dhaecker
Copy link
Contributor

Description

  • Adding locators to wait for in PWA webdriver
  • Updating Magento webdriver to correctly use loading icon locators
  • Updating Magento webdriver to use pageload_timeout

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@dhaecker
PWA-691: Fix Waits In PWA MFTF MagentoPwaWebDriver
d3d5b28 
- Adding locators to wait for in PWA webdriver
- Updating Magento webdriver to correctly use loading icon locators
- Updating Magento webdriver to use pageload_timeout
@dhaecker
PWA-691: Fix Waits In PWA MFTF MagentoPwaWebDriver
15b9b29 
- Adding locators to wait for in PWA webdriver
@coveralls
Copy link

coveralls commented Jun 16, 2020 •
edited

Coverage Status

Coverage remained the same at 55.85% when pulling 821a4d5 on magento-obsessive-owls:PWA-691 into 360beb4 on magento:develop.

@dhaecker
PWA-691: Fix Waits In PWA MFTF MagentoPwaWebDriver
c502e46 
- Fixing locators to wait for in PWA webdriver
@dhaecker
Copy link
Contributor Author

Jenkins build: https://m2build-ur-4.devops.magento.com/job/All-User-Requested-Tests/953/

@dhaecker
Copy link
Contributor Author

Jenkins build w/ mftf feature branch in ce & ee composer.json:

@okolesnyk okolesnyk merged commit edb5c49 into magento:develop Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okolesnyk okolesnyk okolesnyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhaecker @coveralls @okolesnyk