Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated monolog/monolog to ^2.2 #832

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Jun 19, 2021

Description

Updated monolog/monolog to ^2.2 as part of the "Platform Health" updates in the main repo.

Related Pull Requests

Fixed Issues

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Partner: EY labels Jun 19, 2021
@drpayyne drpayyne force-pushed the package/monolog branch 2 times, most recently from 0a05249 to 11a6208 Compare June 19, 2021 14:38
@drpayyne
Copy link
Contributor Author

Hi @sivaschenko, I've fixed the failing tests, but the two PHPUnit checks are failing due to some resource error. I'm not sure how to fix it from my side. Could you please check on this? Thanks.
image

@sivaschenko
Copy link
Member

@jilu1 can you please prioritize this pull request to include the changes in the earliest MFTF release, as it blocks the dependency update in the Magento core.

composer.lock Outdated Show resolved Hide resolved
@sivaschenko
Copy link
Member

@drpayyne is it possible to debug Unit tests by running https://github.com/magento/magento2-functional-testing-framework/blob/develop/bin/phpunit-checks locally to try to identify the root cause?

@sivaschenko
Copy link
Member

@drpayyne actually I can see the same failure in another PR #830

So it might not be related to the changes in the pull request

@jilu1 is that a known issue?

@drpayyne
Copy link
Contributor Author

Updated commits to use Compoer 2.0.14 to prevent unnecessary lock file changes.

@jilu1
Copy link
Contributor

jilu1 commented Jun 21, 2021

@drpayyne
Thank you for your PR!

You can ignore the Error: Resource not accessible by integration for now. This error only happens in this public repository and not in our mirror internal repository. We will investigate the issue soon.

@jilu1
Copy link
Contributor

jilu1 commented Jun 23, 2021

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

@jilu1
Copy link
Contributor

jilu1 commented Jun 23, 2021

@sivaschenko
Is this monolog/monolog upgrade targeted for Magento 2.4-develop?

@sivaschenko
Copy link
Member

@jilu1 Magento pull requests are updated with reference to the branch of this pull request for MFTF. Tests are running in magento/magento2#33226

@magento-cicd2 magento-cicd2 merged commit be72ae6 into magento:develop Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: EY partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants