Removed usage of AspectMock in AnnotationsCheckTest.php #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: EY
partners-contribution
|
@drpayyne Same here. Please ignore the |
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
jilu1
reviewed
Jun 25, 2021
| )->make(); | ||
| $test = $this->createMock(TestObject::class); | ||
|
|
||
| $test->expects($this->once())->method('getAnnotations')->willReturn($annotations); |
There was a problem hiding this comment.
Can we also add $test->expects($this->once())->method('getName')->willReturn('AnnotationsCheckTest');?
There was a problem hiding this comment.
Never mind. Actually getName() is not invoked in this test case.
There was a problem hiding this comment.
Yes, I added that expectation with a once and the test failed, that's why I removed it. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed usage of AspectMock in
\tests\unit\Magento\FunctionalTestFramework\StaticCheck\AnnotationsCheckTestFixed Issues (if relevant)
Resolves magento/magento2#33288
Contribution checklist