Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed usage of AspectMock in DeprecatedEntityUsageCheckTest #838

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Removed usage of AspectMock in DeprecatedEntityUsageCheckTest #838

merged 1 commit into from
Jun 28, 2021

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Jun 23, 2021 •
edited

Description

Removed usage of AspectMock in \tests\unit\Magento\FunctionalTestFramework\StaticCheck\DeprecatedEntityUsageCheckTest

Fixed Issues (if relevant)

  1. [MFTF] Replace AspectMock with PHPUnit for DeprecatedEntityUsageCheckTest magento2#33298

Resolves magento/magento2#33298

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: EY partners-contribution Pull Request is created by Magento Partner labels Jun 23, 2021
@jilu1
Copy link
Contributor

jilu1 commented Jun 23, 2021

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

@magento-cicd2 magento-cicd2 merged commit 4c1c51a into magento:develop Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accept acknowledged in progress Partner: EY partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MFTF] Replace AspectMock with PHPUnit for DeprecatedEntityUsageCheckTest
4 participants
@drpayyne @jilu1 @magento-engcom-team @magento-cicd2