MFTF-33305: Eliminate AspectMock from ObjectExtensionUtilTest #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohdan-harniuk
force-pushed
the
improvement/m2-33305-eliminate-aspect-mock-from-object-extension-util-test
branch
from
082046c
to
ef4f9ea
Compare
bohdan-harniuk
commented
Jul 21, 2021
| */ | ||
| public function setUp(): void | ||
| protected function setUp(): void | ||
| { | ||
| TestLoggingUtil::getInstance()->setMockLoggingUtil(); | ||
| $resolverMock = new MockModuleResolverBuilder(); |
There was a problem hiding this comment.
bohdan-harniuk
added
Partner: Atwix
partners-contribution
andrewbess
previously approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Hello @bohdan-harniuk
Thank you for contribution.
Your changes look good for me.
|
Hello, @jilu1 In this task, we don't have any new singletons created. Please, proceed with the code review! Thanks, Bohdan |
andrewbess
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Hello @bohdan-harniuk
Thank you for your contribution.
The changes look well for me.
5 tasks
5 tasks
5 tasks
jilu1
approved these changes
Jul 30, 2021
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminated AspectMock usage in the \tests\unit\Magento\FunctionalTestFramework\Test\Util\ObjectExtensionUtilTest.
Fixed Issues (if relevant)
Additional information
As the main idea of this issue to eliminate AspectMock usage in the ObjectExtensionUtilTest class, AspectMock usage eliminated only partially in the MockModuleResolverBuilder. It is a required action because in that class the \Magento\FunctionalTestingFramework\Util\ModuleResolver mocked instance hardcoded to be retrieved by the ObjectManager mocked object on its create method without any argument.
Contribution checklist