Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF-33585: Eliminated AspectMock usage from TestLoggingUtil #864

Merged
merged 1 commit into from
Jul 30, 2021
Merged

MFTF-33585: Eliminated AspectMock usage from TestLoggingUtil #864

merged 1 commit into from
Jul 30, 2021

Conversation

bohdan-harniuk
Copy link
Contributor

Description

Eliminated usage of AspectMock from the \tests\unit\Util\TestLoggingUtil.

Fixed Issues (if relevant)

  1. [MFTF] Eliminate AspectMock from TestLoggingUtil (Complex!) magento2#33585: [MFTF] Eliminate AspectMock from TestLoggingUtil (Complex!)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backwards-incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 26, 2021
@bohdan-harniuk bohdan-harniuk force-pushed the improvement/mftf-33585-eliminate-aspect-mock-from-test-logging-util branch from faa611f to 35c190d Compare July 26, 2021 12:58
andrewbess
andrewbess reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bohdan-harniuk
It looks great for me.
Thank you for your contribution.

@andrewbess andrewbess self-assigned this Jul 26, 2021
@KevinBKozan KevinBKozan self-requested a review July 26, 2021 19:49
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 7cf80f2 into magento:develop Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

@jilu1 jilu1 Awaiting requested review from jilu1

@KevinBKozan KevinBKozan Awaiting requested review from KevinBKozan

Assignees

@andrewbess andrewbess

Labels
in progress Partner: Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bohdan-harniuk @andrewbess @KevinBKozan @magento-engcom-team @magento-devops-reposync-svc