Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the csharpru/vault-php-guzzle6-transport not needed dependency #870

Merged

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Aug 19, 2021

Description

This PR aims to remove the dependency on Guzzle6transport, in order to be able to update the guzzlehttp/guzzle package to the latest 7.3.0 version. The current csharpru/vault-php-guzzle6-transport package's version, allows only "guzzlehttp/guzzle": "~6.2".

Fixed Issues (if relevant)

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 19, 2021
@eduard13 eduard13 requested a review from jilu1 August 19, 2021 12:50
@eduard13 eduard13 changed the title Removing the Guzzle6transport's not needed dependency Removing the csharpru/vault-php-guzzle6-transport not needed dependency Aug 19, 2021
@jilu1
Copy link
Contributor

jilu1 commented Aug 19, 2021

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

andrewbess
andrewbess previously approved these changes Aug 20, 2021
@jilu1
Copy link
Contributor

jilu1 commented Aug 20, 2021

@eduard13
Currently Magento platform-health branch has guzzlehttp/guzzle": "^6.3.3", which is conflict with change in this PR. Will you bump guzzlehttp/guzzle version for Magento soon? If not, we will have no working branch for build.

@eduard13
Copy link
Contributor Author

Hi @jilu1, we already have the PRs for CE and EE, however we're still checking what's wrong with the failed builds. It might be related somehow with the MFTF forked repo that we're using temporary there.

Let's postpone this PR for now.

Thank you.

@eduard13
Copy link
Contributor Author

eduard13 commented Sep 1, 2021

Hi @jilu1, the PRs where we're updating guzzlehttp/guzzle are green for both CE and EE (that include the changes of this PR), however let's wait delivering this until you're preparing for a new release version.

Thank you.

@jilu1
Copy link
Contributor

jilu1 commented Sep 3, 2021

Hi @jilu1, the PRs where we're updating guzzlehttp/guzzle are green for both CE and EE (that include the changes of this PR), however let's wait delivering this until you're preparing for a new release version.

Thank you.

@eduard13
We can merge this PR to develop without making a release if you will merge CE and EE soon. Could you confirm?

@eduard13
Copy link
Contributor Author

eduard13 commented Sep 3, 2021

@jilu1, this will require Magento to rely on your develop branch, which isn’t the option that we’d like to go (as far as I understood). That’s why is more preferable to wait for your next release.

@jilu1
Copy link
Contributor

jilu1 commented Sep 3, 2021

@jilu1, this will require Magento to rely on your develop branch, which isn’t the option that we’d like to go (as far as I understood). That’s why is more preferable to wait for your next release.

Ok, let's do that

@andrewbess
Copy link
Contributor

Hello @jilu1.
We are already checking system with PHP 8.0, but we cannot run builds without these changes.
Could you please merge it into develop branch.
Thank you in advance.

@jilu1
Copy link
Contributor

jilu1 commented Sep 7, 2021

@andrewbess @eduard13
Sure. Please update branch and resolve conflict.

@andrewbess
Copy link
Contributor

Hello @jilu1
The branch has been update.
There were not merge-conflicts.

@jilu1
Copy link
Contributor

jilu1 commented Sep 7, 2021

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 2a3bd28 into magento:develop Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants