Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AC-1193: Fix broken MFTF tests #872

Merged
merged 1 commit into from
Sep 9, 2021
Merged

AC-1193: Fix broken MFTF tests #872

merged 1 commit into from
Sep 9, 2021

Conversation

xmav
Copy link
Contributor

@xmav xmav commented Sep 9, 2021

Description

This PR contain fix to revert back test and test object generation to previous behavior

Fixed Issues (if relevant)

  1. https://jira.corp.magento.com/browse/AC-1193: Fix broken MFTF tests

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@jilu1 jilu1 self-requested a review September 9, 2021 19:22
@jilu1
Copy link
Contributor

jilu1 commented Sep 9, 2021

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

jilu1
jilu1 approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on this bug!

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit b0c261e into magento:develop Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
approved in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xmav @jilu1 @magento-engcom-team @magento-devops-reposync-svc