Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for isBuiltin method (for PHP 8 compatibility) #873

Conversation

karyna-tsymbal-atwix
Copy link
Contributor

Description

Adds an additional check to avoid fatal error when using ReflectionUnionType::isBuiltin() method in PHP8
(see details in the related issue)

Related Issues

  1. Check and update codebase to avoid fatal error for ReflectionType::isBuiltin() magento2#34194: Check and update codebase to avoid fatal error for ReflectionType::isBuiltin()

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 1, 2021
andrewbess
andrewbess previously approved these changes Oct 14, 2021
@jilu1
Copy link
Contributor

jilu1 commented Oct 14, 2021

@m2-github-services
Copy link

@jilu1 the Pull Request is successfully imported.

@andrewbess andrewbess self-assigned this Oct 15, 2021
@jilu1 jilu1 added the approved label Oct 18, 2021
@jilu1
Copy link
Contributor

jilu1 commented Oct 18, 2021

@karyna-tsymbal-atwix
Thank you for your PR! It will get merged soon.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 5a3f391 into magento:develop Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants