Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name showing on windows #929

Closed
hryvinskyi opened this issue Jan 21, 2022 · 10 comments · Fixed by #1013
Closed

Package name showing on windows #929

hryvinskyi opened this issue Jan 21, 2022 · 10 comments · Fixed by #1013
Assignees
Labels
bug planned-release-4.3.0 Priority: P1 Needs to be fixed before any other issues
Projects

Comments

@hryvinskyi
Copy link
Member

Describe the bug (*)

When creating a module in the package directory showed "Package Name" input https://i.imgur.com/XyGBfTe.png
and when click "OK" module create in incorect path: https://i.imgur.com/Q03fpqU.png
plugin works on Linux

To Reproduce (*)

Steps to reproduce the behavior:

  1. Go to '/app/code/PackageVendorDir'
  2. Click right button on mouse -> New -> Magento 2 Module
  3. Fill All fields
  4. See error

Please complete the following information: (*)

  • OS: Windows 11
  • PhpStorm/Intellij version: 2022.3.1
  • Plugin Version: 4.2.1
@hryvinskyi hryvinskyi added the bug label Jan 21, 2022
@m2-assistant
Copy link

m2-assistant bot commented Jan 21, 2022

Hi @hryvinskyi. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@Iamwade
Copy link
Collaborator

Iamwade commented Jan 21, 2022

@hryvinskyi Hi!
Thanks for the bug report. I tried to reproduce on Mac OS but everything works fine for me. As far as I understand, everything works well on Linux too.
Please clarify, were you able to reproduce this error only on Windows?

Thank you.

@bohdan-harniuk
Copy link
Collaborator

Hello, @hryvinskyi!

Please, check comment from @Iamwade.
I could not reproduce this bug as well:

Screenshot 2022-01-23 at 14 23 14

Regards,

@hryvinskyi
Copy link
Member Author

hryvinskyi commented Jan 25, 2022

@Iamwade Hi!
Yes, this bug i can reproduce only on wondows 10 / windows 11 2022-01-25_20-34-32
On Linux it works fine for me

@bohdan-harniuk
Copy link
Collaborator

Hi, @hryvinskyi!

Thank you for your response!
We will try to solve this issue.

Regards,

@bohdan-harniuk bohdan-harniuk added this to To do in Bugfix via automation Jan 25, 2022
@bohdan-harniuk bohdan-harniuk added Priority: P1 Needs to be fixed before any other issues next release labels Jan 25, 2022
@doninAtwix
Copy link
Contributor

@magento I am working on this

@doninAtwix
Copy link
Contributor

Hi @bohdan-harniuk .
This issue has been reproduced on the windows/macOs/linux operation systems.

Screenshot 2022-02-18 at 16 44 57

Thank you.

@bohdan-harniuk
Copy link
Collaborator

Hello, @doninAtwix!

Thank you for your work here!
Please, fix this issue.

Hello, @hryvinskyi!
We will fix this issue and include it into the upcoming release.

Regards,

@bohdan-harniuk
Copy link
Collaborator

The original reported issue was not about creating new module in the new directory, but about creating new module with the package name in the valid package directory.

This issue also was reproduced by the @doninAtwix on the windows OS.

It will be fixed as well.

@hryvinskyi
Copy link
Member Author

@bohdan-harniuk @doninAtwix thanks for news

Bugfix automation moved this from To do to Done Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug planned-release-4.3.0 Priority: P1 Needs to be fixed before any other issues
Projects
Development

Successfully merging a pull request may close this issue.

4 participants