Source UPWARD Path From Config #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsche
suggested changes
Jan 31, 2019
|
|
||
| if (empty($upwardConfig)) { | ||
| throw new \RuntimeException('Environment variable ' . static::VAR_UPWARD_CONFIG . 'not set.'); | ||
| throw new \RuntimeException('Environment variable ' . static::VAR_UPWARD_CONFIG . ' not set.'); |
There was a problem hiding this comment.
Need to fix the constant name, and should probably update the message. (Thanks for fixing the missing space, I was annoyed at myself for leaving it off)
There was a problem hiding this comment.
Whoops, all fixed now.
bbatsche
approved these changes
Feb 1, 2019
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 10, 2020
* PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP * PWA-1049: Prerender.io support for UPWARD-PHP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.